Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix storybook styled-jsx example with styled-jsx 5 #31357

Merged
merged 2 commits into from Nov 15, 2021
Merged

Fix storybook styled-jsx example with styled-jsx 5 #31357

merged 2 commits into from Nov 15, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Nov 12, 2021

Documentation / Examples

  • Make sure the linting passes by running yarn lint

x-ref: vercel/styled-jsx#761

Since next.js is using styled-jsx v5 beta now, it requires wrapping a StyleRegistry component on the root top.
ref: styled-jsx doc

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team examples Issue/PR related to examples labels Nov 12, 2021
@huozhi huozhi changed the title Update storybook styled-jsx example Fix storybook styled-jsx example with styled-jsx 5 Nov 14, 2021
@kodiakhq kodiakhq bot merged commit 0afc1d2 into vercel:canary Nov 15, 2021
@huozhi huozhi mentioned this pull request Dec 22, 2021
Merged
kodiakhq bot pushed a commit that referenced this pull request Dec 22, 2021
@huozhi
Reduce styled-jsx size in client bundle (#32730)
ec3ca39 
We introduced the `StyleRegistry` on server side to make it concurrent safe for requests. For client we can have only 1 registry since there's only 1 instance per browser window. Keep consistence with previous usage

Closes #32417
Closes #30377

Revert change in #31357, it's not required anymore
@huozhi huozhi deleted the examples/update-with-storybook branch December 22, 2021 22:22
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@leerob leerob Awaiting requested review from leerob

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huozhi @timneutkens @ijjk