Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for legacy decorators through tsconfig/jsconfig #31376

Merged
merged 3 commits into from Nov 13, 2021
Merged

Add support for legacy decorators through tsconfig/jsconfig #31376

merged 3 commits into from Nov 13, 2021

Conversation

timneutkens
Copy link
Member

Fixes #31375

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Nov 13, 2021
kdy1
kdy1 reviewed Nov 13, 2021
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one thing which may not be an intentional modification.

packages/next/build/jest/jest.ts Show resolved Hide resolved
kdy1
kdy1 reviewed Nov 13, 2021
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one change which may not be an intentional change.

@ijjk

This comment has been minimized.

Sign in to view
kdy1
kdy1 approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good now.

@ijjk
Copy link
Member

ijjk commented Nov 13, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
buildDuration 22.7s 22.1s -522ms
buildDurationCached 4.6s 4.3s -261ms
nodeModulesSize 335 MB 335 MB ⚠️ +1.18 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.873 3.849 -0.02
/ avg req/sec 645.47 649.45 +3.98
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.07 2.062 -0.01
/error-in-render avg req/sec 1207.74 1212.49 +4.75
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28.3 kB 28.3 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.2 kB 72.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.44 kB 4.44 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.3 kB 13.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
index.html gzip 524 B 524 B ✓
link.html gzip 535 B 535 B ✓
withRouter.html gzip 517 B 517 B ✓
Overall change 1.58 kB 1.58 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
buildDuration 24.1s 23.8s -321ms
buildDurationCached 4.3s 4.3s ⚠️ +39ms
nodeModulesSize 335 MB 335 MB ⚠️ +1.18 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.849 3.777 -0.07
/ avg req/sec 649.54 661.87 +12.33
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.019 2.043 ⚠️ +0.02
/error-in-render avg req/sec 1238.45 1223.82 ⚠️ -14.63
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.5 kB 28.5 kB ✓
webpack-HASH.js gzip 1.43 kB 1.43 kB ✓
Overall change 72.5 kB 72.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.46 kB 4.46 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.91 kB 1.91 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 13.2 kB 13.2 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/legacy-decorators Change
index.html gzip 521 B 521 B ✓
link.html gzip 533 B 533 B ✓
withRouter.html gzip 515 B 515 B ✓
Overall change 1.57 kB 1.57 kB ✓
Commit: 76d657d

@timneutkens timneutkens merged commit e0531e3 into vercel:canary Nov 13, 2021
@timneutkens timneutkens deleted the add/legacy-decorators branch November 13, 2021 17:26
@viczam
Copy link

viczam commented Nov 28, 2021

can you please also add "decoratorMetadata": true to swc?

@sannajammeh
Copy link
Contributor

I've run into the same problem as @viczam . This completely breaks compatibility with libraries like next-api-decorators.
"decoratorMetadata": true should be enabled.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for legacy decorators when enabled in tsconfig/jsconfig
5 participants
@timneutkens @ijjk @viczam @sannajammeh @kdy1