Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc & fix styled-jsx #31407

Merged
merged 11 commits into from Nov 15, 2021
Merged

Update swc & fix styled-jsx #31407

merged 11 commits into from Nov 15, 2021

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 15, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Fixes #30480.
Fixes #30570.

Also, this PR applies

This fixes #31291

@ijjk
Copy link
Member

ijjk commented Nov 15, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-css-2 Change
buildDuration 17.1s 17.3s ⚠️ +238ms
buildDurationCached 3.6s 3.4s -215ms
nodeModulesSize 335 MB 335 MB -9 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-css-2 Change
/ failed reqs 0 0
/ total time (seconds) 2.827 2.747 -0.08
/ avg req/sec 884.42 909.96 +25.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.399 1.393 -0.01
/error-in-render avg req/sec 1786.63 1794.98 +8.35
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-css-2 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-css-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-css-2 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-css-2 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-css-2 Change
index.html gzip 522 B 522 B
link.html gzip 534 B 534 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-css-2 Change
buildDuration 18.5s 18.4s -160ms
buildDurationCached 3.4s 3.6s ⚠️ +204ms
nodeModulesSize 335 MB 335 MB -9 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-css-2 Change
/ failed reqs 0 0
/ total time (seconds) 2.817 2.709 -0.11
/ avg req/sec 887.34 923.02 +35.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.326 1.276 -0.05
/error-in-render avg req/sec 1885.77 1958.83 +73.06
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-css-2 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-css-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-css-2 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-css-2 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-css-2 Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 517 B 517 B
Overall change 1.57 kB 1.57 kB
Commit: 457609f

@timneutkens timneutkens merged commit 6fd4438 into vercel:canary Nov 15, 2021
@timneutkens timneutkens deleted the swc-css-2 branch November 15, 2021 08:27
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants