Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Clarity About Downloading and Self-Hosting a Font File #33054

Closed
MaedahBatool opened this issue Jan 6, 2022 · 3 comments
Closed

Add Clarity About Downloading and Self-Hosting a Font File #33054

MaedahBatool opened this issue Jan 6, 2022 · 3 comments
Assignees
@MaedahBatool
Milestone
backlog

Comments

@MaedahBatool
Copy link
Contributor

What is the improvement or update you wish to see?

They’re asking if you should download and “self host” the font file, or if you should include a link in your head to fetch it from a CDN like Google Fonts. If you self-host, our font optimization does not work

Add details on how users can download and handle self-hosted fonts.

Is there any context that might help us understand?

Reference Slack Thread

Does the docs page already exist? Please link to it.

https://nextjs.org/docs/basic-features/font-optimization
@MaedahBatool MaedahBatool added the Documentation Related to Next.js' official documentation. label Jan 6, 2022
@MaedahBatool MaedahBatool added this to the backlog milestone Jan 6, 2022
@MaedahBatool MaedahBatool changed the title Docs: Add Clarity About Downloading and Self-Hosting a Font File Add Clarity About Downloading and Self-Hosting a Font File Jan 6, 2022
@MaedahBatool MaedahBatool self-assigned this Jan 6, 2022
@balazsorban44 balazsorban44 removed the Documentation Related to Next.js' official documentation. label Jan 6, 2022
@molebox
Copy link
Contributor

molebox commented Jan 27, 2022

Hey @MaedahBatool whats the status of this?

@MaedahBatool MaedahBatool mentioned this issue Jan 28, 2022
Merged
2 tasks
@MaedahBatool
Copy link
Contributor Author

Hey @MaedahBatool whats the status of this?

@molebox PR done ✅

kodiakhq bot pushed a commit that referenced this issue Feb 1, 2022
@MaedahBatool
Add Clarity About Downloading and Self-Hosting a Font File (#33760)
af0d082 
Details about downloading and self-hosting font files were missing from our[ Font Optimization docs](https://nextjs.org/docs/basic-features/font-optimization). This PR addresses these changes.

## Bug

- [x] Related issues linked using #33054

## Documentation / Examples

- [x] Make sure the linting passes by running `yarn lint`
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
@MaedahBatool @natew
Add Clarity About Downloading and Self-Hosting a Font File (vercel#33760
9b14ee5 
)

Details about downloading and self-hosting font files were missing from our[ Font Optimization docs](https://nextjs.org/docs/basic-features/font-optimization). This PR addresses these changes.

## Bug

- [x] Related issues linked using vercel#33054

## Documentation / Examples

- [x] Make sure the linting passes by running `yarn lint`
@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MaedahBatool MaedahBatool

Labels
None yet
Projects
None yet
Milestone
backlog
Development

No branches or pull requests
3 participants
@MaedahBatool @balazsorban44 @molebox