Fix getServerSideProps hanging in dev on early end #33366
Merged
+119
−139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where calling
res.end()
isgetServerSideProps
would cause the request to hang in development due to ourProxy
aroundres
causing internalServerResponse
fields to not be available (related post). I also migrated ourgetServerSideProps
test suite to an e2e suite with a test for this case.Bug
fixes #number
contributing.md
Fixes: #15118
Fixes: #32824
Closes: #33129