Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable jest hoist transform when using next/jest #33731

Merged
merged 5 commits into from
Jan 31, 2022
Merged

Enable jest hoist transform when using next/jest #33731

merged 5 commits into from
Jan 31, 2022
+101 −5

Conversation

timneutkens
Copy link
Member

@timneutkens timneutkens commented Jan 27, 2022 •
edited
Loading

Fixes #32539

Implements what was shared at #32539 (comment).

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Sorry, something went wrong.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 27, 2022
@timneutkens timneutkens mentioned this pull request Jan 27, 2022
Closed
@ijjk

This comment has been minimized.

Sign in to view
bybruno
bybruno reviewed Jan 27, 2022
View reviewed changes
@timneutkens
Add test for mocking

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
ac23010
@ijjk

This comment has been minimized.

Sign in to view
@timneutkens
Merge branch 'canary' into fix/jest-mock

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
6694be1
@ijjk

This comment has been minimized.

Sign in to view
huozhi
huozhi previously approved these changes Jan 31, 2022
View reviewed changes
@huozhi huozhi self-requested a review January 31, 2022 14:47
@timneutkens
Add default for packageJson

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
5e661e4
@ijjk

This comment has been minimized.

Sign in to view
@kodiakhq
Merge branch 'canary' into fix/jest-mock

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
e8b21b6
@ijjk
Copy link
Member

ijjk commented Jan 31, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
buildDuration 12.9s 12.7s -152ms
buildDurationCached 3.3s 3.3s -12ms
nodeModulesSize 358 MB 358 MB ⚠️ +452 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.993 2.949 -0.04
/ avg req/sec 835.37 847.62 +12.25
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.386 1.408 ⚠️ +0.02
/error-in-render avg req/sec 1804.1 1775.24 ⚠️ -28.86
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.2 kB 27.2 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71 kB 71 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
_app-HASH.js gzip 1.37 kB 1.37 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.93 kB 4.93 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
index.html gzip 530 B 530 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
buildDuration 16s 16.4s ⚠️ +389ms
buildDurationCached 3.3s 3.3s ⚠️ +10ms
nodeModulesSize 358 MB 358 MB ⚠️ +452 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.017 2.987 -0.03
/ avg req/sec 828.66 836.95 +8.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.401 1.413 ⚠️ +0.01
/error-in-render avg req/sec 1784.58 1769.86 ⚠️ -14.72
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.3 kB 27.3 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 4.97 kB 4.97 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.21 kB 2.21 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js fix/jest-mock Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: e8b21b6

@kodiakhq kodiakhq bot merged commit 3bac02e into vercel:canary Jan 31, 2022
@spence-novata spence-novata mentioned this pull request Feb 2, 2022
Closed
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@timneutkens @natew
Enable jest hoist transform when using next/jest (vercel#33731)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
1e71865 
Fixes vercel#32539

Implements what was shared at vercel#32539 (comment).



## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bybruno bybruno

@huozhi huozhi

@ijjk ijjk

@padmaia padmaia

@shuding shuding

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mocking issue when using Jest with the Rust compiler (next/jest)
4 participants
@timneutkens @ijjk @huozhi @bybruno