Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken data fetching links in docs #33766

Merged

Conversation

MaedahBatool
Copy link
Contributor

Links were broken for the new Data Fetching docs page. This PR fixes these links.

Bug

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Copy link
Contributor

@molebox molebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double check in #next but im pretty sure we add the file extension to paths. Also the index page is called overview, otherwise, lgtm!

docs/advanced-features/custom-error-page.md Outdated Show resolved Hide resolved
docs/basic-features/eslint.md Outdated Show resolved Hide resolved
molebox
molebox previously approved these changes Jan 28, 2022
@leerob
Copy link
Member

leerob commented Jan 28, 2022

Correct, we add the .md extension to paths so it works for both links inside GitHub, as well as when deployed on /docs.

@styfle styfle changed the title Maedah broken data fetching links Fix broken data fetching links in docs Jan 31, 2022
molebox
molebox previously approved these changes Feb 10, 2022
errors/large-page-data.md Outdated Show resolved Hide resolved
errors/gssp-no-mutating-res.md Show resolved Hide resolved
errors/prerender-error.md Outdated Show resolved Hide resolved
@molebox
Copy link
Contributor

molebox commented Mar 29, 2022

@MaedahBatool is this still valid?

@MaedahBatool
Copy link
Contributor Author

@MaedahBatool is this still valid?

Yes, it is. Looking into why it's failing.

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the linting and merge conflict. @MaedahBatool you can run yarn lint-fix in the project root to automatically apply the prettier fixes. This should be good to land now but will leave approving up to @molebox

@MaedahBatool
Copy link
Contributor Author

I've fixed the linting and merge conflict. @MaedahBatool you can run yarn lint-fix in the project root to automatically apply the prettier fixes. This should be good to land now but will leave approving up to @molebox

Thanks for assisting with this PR. I'll run the linter now.

@ijjk ijjk added the examples Issue/PR related to examples label Apr 15, 2022
@ijjk
Copy link
Member

ijjk commented Apr 15, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
buildDuration 20.2s 20.4s ⚠️ +197ms
buildDurationCached 7.7s 7.7s ⚠️ +53ms
nodeModulesSize 485 MB 485 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
/ failed reqs 0 0
/ total time (seconds) 4.496 4.544 ⚠️ +0.05
/ avg req/sec 556.03 550.23 ⚠️ -5.8
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.097 2.12 ⚠️ +0.02
/error-in-render avg req/sec 1192.19 1179.41 ⚠️ -12.78
Client Bundles (main, webpack)
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72 kB 72 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 192 B 192 B
amp-HASH.js gzip 309 B 309 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 3.04 kB 3.04 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.36 kB 2.36 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 319 B 319 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
_buildManifest.js gzip 461 B 461 B
Overall change 461 B 461 B
Rendered Page Sizes
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
index.html gzip 531 B 531 B
link.html gzip 543 B 543 B
withRouter.html gzip 524 B 524 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
buildDuration 23.1s 23s -121ms
buildDurationCached 7.6s 7.5s -77ms
nodeModulesSize 485 MB 485 MB
Page Load Tests Overall increase ✓
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
/ failed reqs 0 0
/ total time (seconds) 4.523 4.404 -0.12
/ avg req/sec 552.67 567.62 +14.95
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.058 2.039 -0.02
/error-in-render avg req/sec 1214.78 1226.18 +11.4
Client Bundles (main, webpack)
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.7 kB 28.7 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.6 kB 72.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 313 B 313 B
css-HASH.js gzip 325 B 325 B
dynamic-HASH.js gzip 3.02 kB 3.02 kB
head-HASH.js gzip 351 B 351 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.78 kB 5.78 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.44 kB 2.44 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 393 B 393 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary MaedahBatool/next.js maedah-broken-data-fetching-links Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB
Commit: 6ef4193

@styfle styfle requested a review from molebox April 19, 2022 22:14
@balazsorban44 balazsorban44 merged commit 60488e6 into vercel:canary Apr 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js docs team PRs by the Next.js docs team examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants