New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update multiple docs pages to follow Docs Content style guide #33855
Merged
kodiakhq
merged 8 commits into
vercel:canary
from
amandeepmittal:apply-consistent-docs-styling
Feb 6, 2022
Merged
Update multiple docs pages to follow Docs Content style guide #33855
kodiakhq
merged 8 commits into
vercel:canary
from
amandeepmittal:apply-consistent-docs-styling
Feb 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amandeepmittal
requested review from
huozhi,
ijjk,
leerob,
padmaia,
shuding,
styfle and
timneutkens
as code owners
February 1, 2022 10:41
amandeepmittal
changed the title
Update Getting Started page to follow docs content style guide
Update multiple docs pages to follow Docs Content style guide
Feb 1, 2022
molebox
previously approved these changes
Feb 1, 2022
leerob
reviewed
Feb 1, 2022
Co-authored-by: Lee Robinson <me@leerob.io>
amandeepmittal
added
the
created-by: Next.js docs team
PRs by the Next.js docs team
label
Feb 1, 2022
leerob
approved these changes
Feb 6, 2022
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
…#33855) This PR addresses minor docs-related styling issues on the Getting Started, Data Fetching (Get Server Side Props), etc pages. It follows the mechanics of the Docs Content Style guide to maintain consistency across all documentation. Also fixes some minor issues such as missing period at the end of a sentence on docs pages like as Data Fetching (getStaticProps). ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have helpful link attached, see `contributing.md` ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses minor docs-related styling issues on the Getting Started, Data Fetching (Get Server Side Props), etc pages. It follows the mechanics of the Docs Content Style guide to maintain consistency across all documentation.
Also fixes some minor issues such as missing period at the end of a sentence on docs pages like as Data Fetching (getStaticProps).
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
yarn lint