Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dismissing full refresh warning for session #33868

Merged
merged 6 commits into from Feb 14, 2022

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 1, 2022

x-ref: #31827
x-ref: #34212

image

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 14, 2022

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
buildDuration 20.7s 20.6s -187ms
buildDurationCached 7.9s 8s ⚠️ +89ms
nodeModulesSize 359 MB 359 MB ⚠️ +368 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
/ failed reqs 0 0
/ total time (seconds) 4.376 4.348 -0.03
/ avg req/sec 571.35 574.99 +3.64
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.042 2.045 0
/error-in-render avg req/sec 1224.29 1222.58 ⚠️ -1.71
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
buildDuration 25.4s 25.3s -49ms
buildDurationCached 8s 7.9s -47ms
nodeModulesSize 359 MB 359 MB ⚠️ +368 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
/ failed reqs 0 0
/ total time (seconds) 4.375 4.362 -0.01
/ avg req/sec 571.37 573.14 +1.77
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.06 2.007 -0.05
/error-in-render avg req/sec 1213.34 1245.42 +32.08
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js feature/ignore-full-refresh Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 5b85c98

@ijjk ijjk changed the title add "Don't show again" to react-dev-overlay full refresh warning Allow dismissing full refresh warning for session Feb 14, 2022
@kodiakhq kodiakhq bot merged commit c20e829 into canary Feb 14, 2022
@kodiakhq kodiakhq bot deleted the feature/ignore-full-refresh branch February 14, 2022 23:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants