Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Form Guide Contents #33913

Merged
merged 20 commits into from Feb 5, 2022
Merged

Conversation

MaedahBatool
Copy link
Contributor

We need to make some quick fixes to the Form guide. The PR changes title and meta description.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-hosted Next.js can run on a server. It doesn't need to be serverless. We need to update this post to remove serverless entirely.

docs/guides/building-forms.md Outdated Show resolved Hide resolved
docs/guides/building-forms.md Outdated Show resolved Hide resolved
docs/guides/building-forms.md Outdated Show resolved Hide resolved
Copy link
Contributor

@molebox molebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rework the conclusion text:

That's about it. After reading this guide, here's what you'll learn:

Maybe something like:

This guide has covered the following: then the bullet points..

Its looking good Maedah! We're nearly there!

docs/guides/building-forms.md Outdated Show resolved Hide resolved
docs/guides/building-forms.md Outdated Show resolved Hide resolved
docs/guides/building-forms.md Outdated Show resolved Hide resolved
docs/guides/building-forms.md Outdated Show resolved Hide resolved
@MaedahBatool
Copy link
Contributor Author

Can we rework the conclusion text:

That's about it. After reading this guide, here's what you'll learn:

Maybe something like:

This guide has covered the following: then the bullet points..

Its looking good Maedah! We're nearly there!

I am on it. ✅

Copy link
Contributor

@molebox molebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Maedah, just the one comment then i think we are good to go!

docs/guides/building-forms.md Outdated Show resolved Hide resolved
docs/guides/building-forms.md Outdated Show resolved Hide resolved
docs/guides/building-forms.md Outdated Show resolved Hide resolved
docs/guides/building-forms.md Outdated Show resolved Hide resolved
docs/guides/building-forms.md Outdated Show resolved Hide resolved
MaedahBatool and others added 5 commits February 4, 2022 13:13
Co-authored-by: Lee Robinson <me@leerob.io>
Co-authored-by: Lee Robinson <me@leerob.io>
Co-authored-by: Lee Robinson <me@leerob.io>
Co-authored-by: Lee Robinson <me@leerob.io>
leerob
leerob previously approved these changes Feb 5, 2022
ijjk
ijjk previously approved these changes Feb 5, 2022
@ijjk ijjk dismissed stale reviews from leerob and themself via eff1920 February 5, 2022 19:02
@kodiakhq kodiakhq bot merged commit 6814ca7 into vercel:canary Feb 5, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
We need to make some quick fixes to the Form guide. The PR changes title and meta description.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [x] Make sure the linting passes by running `yarn lint`


Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js docs team PRs by the Next.js docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants