Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix suffix ordering while streaming #34011

Merged
merged 3 commits into from Feb 5, 2022
Merged

Fix suffix ordering while streaming #34011

merged 3 commits into from Feb 5, 2022

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Feb 5, 2022

Fix an issue where the suffix was being flushed before the inline RSC data, and add a test case to catch it.

@ijjk ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Feb 5, 2022
ijjk
ijjk previously approved these changes Feb 5, 2022
View reviewed changes
@devknoll devknoll closed this Feb 5, 2022
@devknoll devknoll reopened this Feb 5, 2022
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Feb 5, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
buildDuration 15.3s 15.1s -141ms
buildDurationCached 5.9s 5.9s ⚠️ +23ms
nodeModulesSize 359 MB 359 MB ⚠️ +1.55 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.162 3.171 ⚠️ +0.01
/ avg req/sec 790.6 788.45 ⚠️ -2.15
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.322 1.344 ⚠️ +0.02
/error-in-render avg req/sec 1891.47 1859.59 ⚠️ -31.88
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 27.4 kB 27.4 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.2 kB 71.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.37 kB 2.37 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 4.94 kB 4.94 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.19 kB 2.19 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
index.html gzip 532 B 532 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
buildDuration 18.6s 18.6s ⚠️ +75ms
buildDurationCached 6s 5.9s -49ms
nodeModulesSize 359 MB 359 MB ⚠️ +1.55 kB
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.155 3.162 ⚠️ +0.01
/ avg req/sec 792.3 790.52 ⚠️ -1.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.335 1.312 -0.02
/error-in-render avg req/sec 1872.59 1905.76 +33.17
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 27.4 kB 27.4 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.36 kB 2.36 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 4.97 kB 4.97 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.21 kB 2.21 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.3 kB 14.3 kB ✓
Client Build Manifests
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary azukaru/next.js x-fix-suffix-ordering Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: 3d7fd02

@ijjk ijjk merged commit 1aeb230 into vercel:canary Feb 5, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@devknoll @natew
Fix suffix ordering while streaming (vercel#34011)
ffdc77e 
* Fix suffix ordering

* Don't start reading until after resolving

* More yak shaving
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@anthonysidesap anthonysidesap anthonysidesap approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devknoll @ijjk @anthonysidesap