Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(next-swc): Update swc #34045

Merged
merged 5 commits into from Feb 8, 2022
Merged

feat(next-swc): Update swc #34045

merged 5 commits into from Feb 8, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 7, 2022 •
edited

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 7, 2022
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Feb 8, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-up-13 Change
buildDuration 18s 17.9s -89ms
buildDurationCached 6.9s 6.8s -116ms
nodeModulesSize 359 MB 359 MB ⚠️ +12 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-up-13 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.749 3.656 -0.09
/ avg req/sec 666.81 683.87 +17.06
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.628 1.57 -0.06
/error-in-render avg req/sec 1535.71 1591.86 +56.15
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-13 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 27.5 kB 27.5 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.2 kB 71.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-13 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-up-13 Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 326 B 326 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 919 B 919 B ✓
image-HASH.js gzip 5.01 kB 5.01 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-13 Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-13 Change
index.html gzip 531 B 531 B ✓
link.html gzip 544 B 544 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-up-13 Change
buildDuration 21.5s 21.2s -287ms
buildDurationCached 6.9s 7.1s ⚠️ +192ms
nodeModulesSize 359 MB 359 MB ⚠️ +12 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up-13 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.636 3.656 ⚠️ +0.02
/ avg req/sec 687.52 683.75 ⚠️ -3.77
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.558 1.557 0
/error-in-render avg req/sec 1604.65 1605.86 +1.21
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-up-13 Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.1 kB 42.1 kB ✓
main-HASH.js gzip 27.5 kB 27.5 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.3 kB 71.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-13 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kdy1/next.js swc-up-13 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 911 B 911 B ✓
image-HASH.js gzip 5.05 kB 5.05 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 2.28 kB 2.28 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.7 kB 14.7 kB ✓
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-13 Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-13 Change
index.html gzip 533 B 533 B ✓
link.html gzip 547 B 547 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: f86acfb

@kodiakhq kodiakhq bot merged commit f1ff0fb into vercel:canary Feb 8, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@kdy1 @natew
feat(next-swc): Update swc (vercel#34045)
ba7507a 
This applies 

 - swc-project/swc#3462

This resolves vercel#30237 (comment)


 - swc-project/swc#3463

This resolves vercel#30237 (comment)

 - swc-project/swc#3480

This resolves vercel#30237 (comment)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kdy1 @ijjk