Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not run lock/stale actions on forks #34053

Merged
merged 2 commits into from Feb 7, 2022

Conversation

balazsorban44
Copy link
Member

The lock and stale actions will always fail on fork repos since they are using secrets that are not shared with the fork workflow runs.

This PR addresses that by limiting the lock and stale actions to bail out on fork repo workflow runs.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Feb 7, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
buildDuration 15.9s 16s ⚠️ +68ms
buildDurationCached 6.1s 7.7s ⚠️ +1.6s
nodeModulesSize 359 MB 359 MB -20 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
/ failed reqs 0 0
/ total time (seconds) 3.241 3.301 ⚠️ +0.06
/ avg req/sec 771.37 757.25 ⚠️ -14.12
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.366 1.381 ⚠️ +0.01
/error-in-render avg req/sec 1829.86 1810.24 ⚠️ -19.62
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.1 kB 71.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.94 kB 4.94 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.17 kB 2.17 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.5 kB 14.5 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
buildDuration 19.3s 19.5s ⚠️ +207ms
buildDurationCached 6.2s 6.1s -70ms
nodeModulesSize 359 MB 359 MB -20 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
/ failed reqs 0 0
/ total time (seconds) 3.337 3.264 -0.07
/ avg req/sec 749.27 765.98 +16.71
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.391 1.416 ⚠️ +0.02
/error-in-render avg req/sec 1797.77 1765.37 ⚠️ -32.4
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.4 kB 27.4 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.97 kB 4.97 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.2 kB 2.2 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.5 kB 14.5 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/limit-actions-on-forks Change
index.html gzip 534 B 534 B
link.html gzip 548 B 548 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 086153b

@kodiakhq kodiakhq bot merged commit 1ac0fc4 into canary Feb 7, 2022
@kodiakhq kodiakhq bot deleted the fix/limit-actions-on-forks branch February 7, 2022 13:23
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
The lock and stale actions will always fail on fork repos since they are using secrets that are not shared with the fork workflow runs.

This PR addresses that by limiting the lock and stale actions to bail out on fork repo workflow runs.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants