Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unneeded and broken plugin #34087

Merged
merged 4 commits into from Feb 8, 2022
Merged

Conversation

sokra
Copy link
Member

@sokra sokra commented Feb 8, 2022

fixes #25484
fixes #34064

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 8, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
buildDuration 21.9s 20.7s -1.2s
buildDurationCached 8.1s 8s -117ms
nodeModulesSize 359 MB 359 MB -2.72 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
/ failed reqs 0 0
/ total time (seconds) 4.672 4.646 -0.03
/ avg req/sec 535.09 538.12 +3.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.165 2.185 ⚠️ +0.02
/error-in-render avg req/sec 1154.85 1144.36 ⚠️ -10.49
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.5 kB 27.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
buildDuration 25s 24.9s -81ms
buildDurationCached 7.8s 7.6s -215ms
nodeModulesSize 359 MB 359 MB -2.72 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
/ failed reqs 0 0
/ total time (seconds) 4.549 4.667 ⚠️ +0.12
/ avg req/sec 549.58 535.72 ⚠️ -13.86
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.11 2.151 ⚠️ +0.04
/error-in-render avg req/sec 1184.88 1162.35 ⚠️ -22.53
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.5 kB 27.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/remove-nextjs-ssr-import Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: e37a5f5

@kodiakhq kodiakhq bot merged commit 451dfa1 into canary Feb 8, 2022
@kodiakhq kodiakhq bot deleted the bugfix/remove-nextjs-ssr-import branch February 8, 2022 15:20
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
fixes vercel#25484
fixes vercel#34064

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
4 participants