Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow node-sass@7 as peer dependency #34107

Merged
merged 6 commits into from Feb 11, 2022
Merged

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Feb 8, 2022

Fixes #34086

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk

This comment has been minimized.

@matamatanot
Copy link
Contributor

matamatanot commented Feb 9, 2022

@balazsorban44
node-sass had dropped support for Node10 since v6.
https://github.com/sass/node-sass/releases/tag/v6.0.0

sass-loader@12 's minimum supported Node.js version is 12.13.0.
https://github.com/webpack-contrib/sass-loader/releases/tag/v12.0.0

Next.js has 12.22.0.
So, I don't think 4 and 5 should be included.

balazsorban44 and others added 2 commits February 9, 2022 11:51
Co-authored-by: matamatanot <39780486+matamatanot@users.noreply.github.com>
@ijjk
Copy link
Member

ijjk commented Feb 9, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
buildDuration 15.3s 15.2s -16ms
buildDurationCached 6.2s 6.1s -105ms
nodeModulesSize 359 MB 359 MB ⚠️ +1.59 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
/ failed reqs 0 0
/ total time (seconds) 2.963 2.981 ⚠️ +0.02
/ avg req/sec 843.63 838.66 ⚠️ -4.97
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.196 1.184 -0.01
/error-in-render avg req/sec 2089.97 2112.03 +22.06
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
buildDuration 19s 18.6s -339ms
buildDurationCached 6s 6s -67ms
nodeModulesSize 359 MB 359 MB ⚠️ +1.59 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
/ failed reqs 0 0
/ total time (seconds) 2.994 2.996 0
/ avg req/sec 834.98 834.34 ⚠️ -0.64
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.179 1.209 ⚠️ +0.03
/error-in-render avg req/sec 2120.87 2068.02 ⚠️ -52.85
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js chore/allow-node-sass-7 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: 639347d

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ijjk ijjk merged commit 7ac9c48 into canary Feb 11, 2022
@ijjk ijjk deleted the chore/allow-node-sass-7 branch February 11, 2022 21:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to request for node-sass@^7.0.0 support
3 participants