Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update failing tests from upstream resource #34110

Merged
merged 3 commits into from Feb 8, 2022

Conversation

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Feb 8, 2022
@ijjk

This comment was marked as outdated.

@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review February 8, 2022 22:31
@ijjk ijjk requested review from padmaia and styfle February 8, 2022 22:32
@ijjk ijjk changed the title Update flakey tests a bit Update flakey tests Feb 8, 2022
@ijjk ijjk changed the title Update flakey tests Update failing tests from upstream resource Feb 8, 2022
@ijjk
Copy link
Member Author

ijjk commented Feb 8, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/flakey-tests Change
buildDuration 18.6s 19.5s ⚠️ +891ms
buildDurationCached 7.1s 7s -127ms
nodeModulesSize 359 MB 359 MB -7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/flakey-tests Change
/ failed reqs 0 0
/ total time (seconds) 4.002 4.155 ⚠️ +0.15
/ avg req/sec 624.68 601.66 ⚠️ -23.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.891 1.968 ⚠️ +0.08
/error-in-render avg req/sec 1321.87 1270.46 ⚠️ -51.41
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/flakey-tests Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.5 kB 27.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.2 kB 71.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/flakey-tests Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/flakey-tests Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/flakey-tests Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/flakey-tests Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js update/flakey-tests Change
buildDuration 22.1s 21.8s -259ms
buildDurationCached 6.9s 6.9s ⚠️ +8ms
nodeModulesSize 359 MB 359 MB -7 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/flakey-tests Change
/ failed reqs 0 0
/ total time (seconds) 3.841 3.987 ⚠️ +0.15
/ avg req/sec 650.85 627.09 ⚠️ -23.76
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.924 2.148 ⚠️ +0.22
/error-in-render avg req/sec 1299.6 1163.89 ⚠️ -135.71
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/flakey-tests Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.5 kB 27.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/flakey-tests Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/flakey-tests Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/flakey-tests Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/flakey-tests Change
index.html gzip 533 B 533 B
link.html gzip 548 B 548 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 4c35ccf

@kodiakhq kodiakhq bot merged commit 3f0a8d9 into vercel:canary Feb 8, 2022
@ijjk ijjk deleted the update/flakey-tests branch February 8, 2022 23:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants