Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required files matching in rsc #34137

Merged
merged 3 commits into from Feb 9, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 9, 2022

Fix the wrong filename evaluation of MIDDLEWARE_FLIGHT_MANIFEST in required files. Besides checking the generated files, check if they're declared correctly in required-server-files.json

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 9, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/match-required-files Change
buildDuration 15.6s 15.6s -85ms
buildDurationCached 6.1s 6.1s -25ms
nodeModulesSize 359 MB 359 MB ⚠️ +22 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/match-required-files Change
/ failed reqs 0 0
/ total time (seconds) 3.171 3.215 ⚠️ +0.04
/ avg req/sec 788.4 777.7 ⚠️ -10.7
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.367 1.387 ⚠️ +0.02
/error-in-render avg req/sec 1829.42 1801.99 ⚠️ -27.43
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/match-required-files Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/match-required-files Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/match-required-files Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/match-required-files Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/match-required-files Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/match-required-files Change
buildDuration 19.2s 19.2s ⚠️ +79ms
buildDurationCached 6.1s 6.1s ⚠️ +67ms
nodeModulesSize 359 MB 359 MB ⚠️ +22 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/match-required-files Change
/ failed reqs 0 0
/ total time (seconds) 3.168 3.203 ⚠️ +0.03
/ avg req/sec 789.02 780.4 ⚠️ -8.62
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.387 1.396 ⚠️ +0.01
/error-in-render avg req/sec 1801.9 1790.25 ⚠️ -11.65
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/match-required-files Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/match-required-files Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/match-required-files Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/match-required-files Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/match-required-files Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: de20ab4

@kodiakhq kodiakhq bot merged commit 52c3d07 into vercel:canary Feb 9, 2022
@huozhi huozhi deleted the fix/match-required-files branch February 9, 2022 20:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants