Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image-optimizer requires in next-server #34141

Merged
merged 1 commit into from Feb 9, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 9, 2022

This ensures we don't attempt requiring image-optimizer when it was configured to not include it e.g. when deployed on Vercel or similar environments, this also updates our test to ensure we don't regress on this.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Fixes: #34134

@ijjk
Copy link
Member Author

ijjk commented Feb 9, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
buildDuration 15.3s 15.5s ⚠️ +267ms
buildDurationCached 6s 6.1s ⚠️ +73ms
nodeModulesSize 359 MB 359 MB ⚠️ +386 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
/ failed reqs 0 0
/ total time (seconds) 3.162 3.114 -0.05
/ avg req/sec 790.6 802.76 +12.16
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.359 1.339 -0.02
/error-in-render avg req/sec 1839.05 1867.65 +28.6
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
buildDuration 18.8s 18.9s ⚠️ +131ms
buildDurationCached 6s 6.1s ⚠️ +59ms
nodeModulesSize 359 MB 359 MB ⚠️ +386 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
/ failed reqs 0 0
/ total time (seconds) 3.156 3.084 -0.07
/ avg req/sec 792.14 810.68 +18.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.385 1.332 -0.05
/error-in-render avg req/sec 1805.18 1877.49 +72.31
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/image-optimizer-check Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 9fe8dbe

@ijjk ijjk merged commit 28f65ff into vercel:canary Feb 9, 2022
@ijjk ijjk deleted the fix/image-optimizer-check branch February 9, 2022 18:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module './image-optimizer' from serverless functions (12.0.11-canary.10)
2 participants