Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy .env file in standalone mode #34143

Merged
merged 8 commits into from Feb 10, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Feb 9, 2022

Ref: #33897

I took a naive approach and simply added .env to the files that need to be copied.

Do we want to include .env.production as well? Ref: https://nextjs.org/docs/basic-features/environment-variables#loading-environment-variables

(I haven't tested what happens if the file does not exist on copy.)

Other files like .env.*local or .env.{test,development} don't make sense to copy.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

packages/next/build/index.ts Outdated Show resolved Hide resolved
@ijjk

This comment was marked as outdated.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 10, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
buildDuration 19.4s 19.7s ⚠️ +370ms
buildDurationCached 7.5s 7.4s -116ms
nodeModulesSize 359 MB 359 MB ⚠️ +603 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
/ failed reqs 0 0
/ total time (seconds) 4.245 4.254 ⚠️ +0.01
/ avg req/sec 588.94 587.73 ⚠️ -1.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.066 2.108 ⚠️ +0.04
/error-in-render avg req/sec 1210.33 1186.06 ⚠️ -24.27
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
buildDuration 23.4s 23.9s ⚠️ +529ms
buildDurationCached 7.4s 7.4s -40ms
nodeModulesSize 359 MB 359 MB ⚠️ +603 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
/ failed reqs 0 0
/ total time (seconds) 4.156 4.257 ⚠️ +0.1
/ avg req/sec 601.6 587.3 ⚠️ -14.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.008 2.031 ⚠️ +0.02
/error-in-render avg req/sec 1245.23 1230.65 ⚠️ -14.58
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js feat/copy-env-file-in-standalone Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: c425cb7

@kodiakhq kodiakhq bot merged commit 46e32ae into canary Feb 10, 2022
@kodiakhq kodiakhq bot deleted the feat/copy-env-file-in-standalone branch February 10, 2022 17:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants