Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error when ts file contains css.resolve #34149

Merged
merged 2 commits into from Feb 10, 2022

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Feb 10, 2022

Throws a more helpful error when css.resolve is used within a .ts file.

Related issue: vercel/styled-jsx#780

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@padmaia padmaia requested a review from kdy1 February 10, 2022 00:45
@ijjk
Copy link
Member

ijjk commented Feb 10, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
buildDuration 20.9s 20.2s -672ms
buildDurationCached 7.7s 7.9s ⚠️ +162ms
nodeModulesSize 359 MB 359 MB -5 B
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
/ failed reqs 0 0
/ total time (seconds) 4.447 4.355 -0.09
/ avg req/sec 562.15 574.11 +11.96
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.179 2.192 ⚠️ +0.01
/error-in-render avg req/sec 1147.33 1140.29 ⚠️ -7.04
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
buildDuration 24.9s 25s ⚠️ +89ms
buildDurationCached 7.8s 7.6s -215ms
nodeModulesSize 359 MB 359 MB -5 B
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
/ failed reqs 0 0
/ total time (seconds) 4.459 4.431 -0.03
/ avg req/sec 560.71 564.26 +3.55
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.214 2.178 -0.04
/error-in-render avg req/sec 1129.36 1148.01 +18.65
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js add/styled-jsx-ts-warning Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: dca5051

@kodiakhq kodiakhq bot merged commit 6c869cf into vercel:canary Feb 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants