Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure standalone server handles SIGTERM #34151

Merged
merged 1 commit into from Feb 10, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 10, 2022

This copies our existing SIGTERM/SIGINT handling for the standalone server we output for outputStandalone to ensure ctrl + c works correctly with Docker.

x-ref:

// Make sure commands gracefully respect termination signals (e.g. from Docker)
process.on('SIGTERM', () => process.exit(0))
process.on('SIGINT', () => process.exit(0))

@ijjk
Copy link
Member Author

ijjk commented Feb 10, 2022

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
buildDuration 17.2s 17s -225ms
buildDurationCached 6.8s 6.9s ⚠️ +116ms
nodeModulesSize 359 MB 359 MB ⚠️ +184 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
/ failed reqs 0 0
/ total time (seconds) 3.539 3.435 -0.1
/ avg req/sec 706.46 727.9 +21.44
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.478 1.493 ⚠️ +0.02
/error-in-render avg req/sec 1692.03 1674.04 ⚠️ -17.99
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
buildDuration 20.7s 20.1s -564ms
buildDurationCached 6.5s 6.7s ⚠️ +133ms
nodeModulesSize 359 MB 359 MB ⚠️ +184 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
/ failed reqs 0 0
/ total time (seconds) 3.554 3.573 ⚠️ +0.02
/ avg req/sec 703.52 699.78 ⚠️ -3.74
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.538 1.542 0
/error-in-render avg req/sec 1625.89 1621.4 ⚠️ -4.49
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/minimal-handle-sigterm Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 5b75922

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it, and it works! Thank you

@balazsorban44 balazsorban44 merged commit b37d49c into vercel:canary Feb 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants