Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error thrown by next/image in the Sanity example #34203

Merged
merged 2 commits into from Feb 10, 2022
Merged

Fix error thrown by next/image in the Sanity example #34203

merged 2 commits into from Feb 10, 2022

Conversation

stipsan
Copy link
Contributor

@stipsan stipsan commented Feb 10, 2022 •
edited

Documentation / Examples

  • Make sure the linting passes by running yarn lint

When firing up examples/cms-sanity you're currently seeing an Server Error:

Error: Invalid sc prop
(https://cdn.sanity.io/images/:dataset/production/:asset.jpg) on 'next/image',
hostname
"cdn.sanity.io" is not
configured under images in your 'next.config.js'
See more info: https://nextjs.org/docs/messages/next-image-unconfigured-host
localhost_3001_

@ijjk ijjk added the examples Issue/PR related to examples label Feb 10, 2022
ijjk
ijjk approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@stipsan
Copy link
Contributor Author

stipsan commented Feb 10, 2022

No probs @ijjk! Just a heads up, we have some more updates coming for next-sanity so expect to see more PRs from us soon! 😄

@ijjk ijjk merged commit ef82e8a into vercel:canary Feb 10, 2022
@stipsan stipsan deleted the fix-sanity-image branch February 11, 2022 09:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stipsan @ijjk