Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dynamic HTML in minimal mode #34222

Merged
merged 5 commits into from Feb 11, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 11, 2022

Follow up for #34068

Let minimalMode render HTML by streaming facilities

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 11, 2022
@ijjk

This comment has been minimized.

@huozhi huozhi changed the title Enable dynamic HTLM in minimalMode Enable dynamic HTLM in minimal mode Feb 11, 2022
@huozhi huozhi marked this pull request as ready for review February 11, 2022 14:44
@ijjk

This comment has been minimized.

@huozhi huozhi requested a review from shuding February 11, 2022 16:44
@ijjk ijjk changed the title Enable dynamic HTLM in minimal mode Enable dynamic HTML in minimal mode Feb 11, 2022
@huozhi huozhi requested a review from shuding February 11, 2022 16:59
@ijjk
Copy link
Member

ijjk commented Feb 11, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
buildDuration 20.9s 21.3s ⚠️ +420ms
buildDurationCached 7.9s 8s ⚠️ +83ms
nodeModulesSize 359 MB 359 MB ⚠️ +68 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
/ failed reqs 0 0
/ total time (seconds) 4.539 4.558 ⚠️ +0.02
/ avg req/sec 550.84 548.45 ⚠️ -2.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.124 2.166 ⚠️ +0.04
/error-in-render avg req/sec 1177.02 1154.34 ⚠️ -22.68
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
buildDuration 25.6s 25.6s -16ms
buildDurationCached 8.2s 8s -165ms
nodeModulesSize 359 MB 359 MB ⚠️ +68 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
/ failed reqs 0 0
/ total time (seconds) 4.563 4.428 -0.13
/ avg req/sec 547.86 564.62 +16.76
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.132 2.15 ⚠️ +0.02
/error-in-render avg req/sec 1172.56 1162.61 ⚠️ -9.95
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/minimal-mode-streaming Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 957ae00

@kodiakhq kodiakhq bot merged commit 477134d into vercel:canary Feb 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
@huozhi huozhi deleted the fix/minimal-mode-streaming branch May 11, 2022 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants