Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncaught error in getInitialProps when runtime is set to nodejs #34228

Merged
merged 9 commits into from Feb 11, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Feb 11, 2022

This PR ensures that the test "should render 500 error correctly" doesn't break when runtime is set to nodejs with serverComponents enabled.

This test case is now moved to the "basic" suite to ensure it doesn't break in both runtimes. And "should not bundle external imports into client builds for RSC" is enabled for the nodejs runtime too.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 11, 2022
@shuding shuding requested a review from huozhi February 11, 2022 14:16
@ijjk

This comment has been minimized.

@shuding shuding marked this pull request as ready for review February 11, 2022 14:53
@shuding shuding marked this pull request as draft February 11, 2022 14:56
@shuding shuding marked this pull request as ready for review February 11, 2022 16:14
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 11, 2022

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/6be1 Change
buildDuration 15.6s 15.4s -161ms
buildDurationCached 6.2s 6.2s -30ms
nodeModulesSize 359 MB 359 MB ⚠️ +1.01 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/6be1 Change
/ failed reqs 0 0
/ total time (seconds) 3.249 3.183 -0.07
/ avg req/sec 769.59 785.43 +15.84
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.357 1.367 ⚠️ +0.01
/error-in-render avg req/sec 1841.83 1829.05 ⚠️ -12.78
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/6be1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/6be1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/6be1 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/6be1 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/6be1 Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/6be1 Change
buildDuration 19.1s 19.1s -34ms
buildDurationCached 6.1s 6.2s ⚠️ +63ms
nodeModulesSize 359 MB 359 MB ⚠️ +1.01 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/6be1 Change
/ failed reqs 0 0
/ total time (seconds) 3.174 3.218 ⚠️ +0.04
/ avg req/sec 787.62 776.94 ⚠️ -10.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.362 1.369 ⚠️ +0.01
/error-in-render avg req/sec 1836.06 1826.58 ⚠️ -9.48
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/6be1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/6be1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/6be1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/6be1 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/6be1 Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 9230993

@kodiakhq kodiakhq bot merged commit 931666d into vercel:canary Feb 11, 2022
@shuding shuding deleted the shu/6be1 branch February 11, 2022 18:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants