Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link for "Delete Query Params in Middleware" error message in next-server.ts #34230

Merged
merged 1 commit into from Feb 11, 2022

Conversation

MaedahBatool
Copy link
Contributor

The link inside next-server.ts file for the "Delete Query Params in Middleware" error message was pointing to a 404 page.

Since we've moved the errors directory to docs/messages in the Next.js repo (See this). The PR adds these changes.

Bug

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented Feb 11, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
buildDuration 15.7s 15.6s -86ms
buildDurationCached 6s 6s -41ms
nodeModulesSize 359 MB 359 MB -4 B
Page Load Tests Overall increase ✓
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
/ failed reqs 0 0
/ total time (seconds) 3.133 3.139 ⚠️ +0.01
/ avg req/sec 797.88 796.39 ⚠️ -1.49
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.358 1.347 -0.01
/error-in-render avg req/sec 1840.37 1855.55 +15.18
Client Bundles (main, webpack, commons)
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
buildDuration 18.8s 18.9s ⚠️ +153ms
buildDurationCached 6s 6s ⚠️ +5ms
nodeModulesSize 359 MB 359 MB -4 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
/ failed reqs 0 0
/ total time (seconds) 3.111 3.085 -0.03
/ avg req/sec 803.7 810.48 +6.78
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.335 1.349 ⚠️ +0.01
/error-in-render avg req/sec 1872 1852.6 ⚠️ -19.4
Client Bundles (main, webpack, commons)
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary MaedahBatool/next.js fix-link-error-message Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 932fdb6

@kodiakhq kodiakhq bot merged commit 361ce87 into vercel:canary Feb 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants