Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link for includeFiles glob reference #34269

Merged
merged 1 commit into from Feb 12, 2022
Merged

Update link for includeFiles glob reference #34269

merged 1 commit into from Feb 12, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 12, 2022

This ensures we reference minimatch since the globs there can have different syntax.

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Closes: #34246

@ijjk ijjk mentioned this pull request Feb 12, 2022
Closed
@ijjk ijjk marked this pull request as ready for review February 12, 2022 15:27
@kodiakhq kodiakhq bot merged commit 2351e5b into vercel:canary Feb 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Output File Tracing not working for ISR page
2 participants
@ijjk @huozhi