Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed all occurrences of etc to match #34280

Merged
merged 1 commit into from Feb 13, 2022
Merged

Changed all occurrences of etc to match #34280

merged 1 commit into from Feb 13, 2022

Conversation

Nutlope
Copy link
Contributor

@Nutlope Nutlope commented Feb 12, 2022

The correct way to use et cetera is to put a period right after and a comma behind it if it's being used as a list. I updated the occurrences in the docs and examples that didn't match these rules.

@ijjk
Copy link
Member

ijjk commented Feb 13, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js consistent-etc Change
buildDuration 15.2s 15.1s -132ms
buildDurationCached 6s 5.9s -56ms
nodeModulesSize 359 MB 359 MB ⚠️ +15 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js consistent-etc Change
/ failed reqs 0 0
/ total time (seconds) 3.047 3.029 -0.02
/ avg req/sec 820.57 825.31 +4.74
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.227 1.202 -0.03
/error-in-render avg req/sec 2036.77 2080.59 +43.82
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js consistent-etc Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js consistent-etc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js consistent-etc Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js consistent-etc Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js consistent-etc Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js consistent-etc Change
buildDuration 18.6s 18.6s -30ms
buildDurationCached 6s 6s -27ms
nodeModulesSize 359 MB 359 MB ⚠️ +15 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js consistent-etc Change
/ failed reqs 0 0
/ total time (seconds) 3.032 3.029 0
/ avg req/sec 824.58 825.45 +0.87
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.202 1.205 0
/error-in-render avg req/sec 2079.15 2073.93 ⚠️ -5.22
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js consistent-etc Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js consistent-etc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js consistent-etc Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js consistent-etc Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js consistent-etc Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 83dd24a

@kodiakhq kodiakhq bot merged commit ca8530f into canary Feb 13, 2022
@kodiakhq kodiakhq bot deleted the consistent-etc branch February 13, 2022 00:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants