Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add link to pageExtensions config in page-without-valid-component.md #34285

Merged
merged 2 commits into from Feb 14, 2022

Conversation

benmvp
Copy link
Contributor

@benmvp benmvp commented Feb 13, 2022

The Page Without Valid React Component explains some ways to fix the problem of Next finding a non-React Component. However, if someone is trying to use .mdx as an extension, or wants to include tests, stories or other non-page files in their pages folder there's nothing for them.

The Custom Page Extensions has all the info to help them out, but adding it to this error page should make it more discoverable.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

…nt.md

The [Page Without Valid React Component](https://nextjs.org/docs/messages/page-without-valid-component) explains some ways to fix the problem of Next finding a non-React Component. However, if someone is trying to use `.mdx` as an extension, or wants to include tests, stories or other non-page files in their `pages` folder there's nothing for them.

The [Custom Page Extensions](https://nextjs.org/docs/api-reference/next.config.js/custom-page-extensions) has all the info to help them out, but adding it to this error page should make it more discoverable.
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit 41ecd5e into vercel:canary Feb 14, 2022
@benmvp benmvp deleted the patch-1 branch February 15, 2022 05:54
@benmvp
Copy link
Contributor Author

benmvp commented Feb 17, 2022

Thanks for the quick merge @ijjk!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants