Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few touch-ups to the docs on web forms in Next #34286

Merged
merged 6 commits into from Feb 14, 2022
Merged

Few touch-ups to the docs on web forms in Next #34286

merged 6 commits into from Feb 14, 2022

Conversation

T-O-R-U-S
Copy link
Contributor

@T-O-R-U-S T-O-R-U-S commented Feb 13, 2022 •
edited

Beyond the minor changes...

  • Added a warning that back-end validation is more secure
  • Fixed a RegEx that I'm damn-near sure is wrong.
  • Returned status codes in the first back-end serverless example
  • Added a link the user can click on to learn what a HTTP method is

Changes that must be reviewed:

  • Does the script tag need explanation? I think all that needs to be said is that you can indeed use it in Next.JS, without much trouble.

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@T-O-R-U-S
Few grammatical touch-ups and stylistic changes
0c2056d 
## Beyond the minor changes...

- Added a warning that back-end validation is more secure
- Fixed a RegEx that I'm damn-near sure is wrong.
- Returned status codes in the first back-end serverless example
- Added a link the user can click on to learn what a HTTP method is

## Changes that must be reviewed:

- Does the `script` tag need explanation? I think all that needs to be said is that you can indeed use it in Next.JS, without much trouble.
@T-O-R-U-S
Copy link
Contributor Author

Repo refuses to clone on my end; I'm incapable of running yarn lint. Would be grateful if somebody else could do so for me :)

@T-O-R-U-S
Copy link
Contributor Author

Managed to get it sorted; passes the lint check!

ijjk
ijjk reviewed Feb 14, 2022
View reviewed changes
docs/guides/building-forms.md Outdated Show resolved Hide resolved
ijjk
ijjk reviewed Feb 14, 2022
View reviewed changes
docs/guides/building-forms.md Outdated Show resolved Hide resolved
ijjk
ijjk reviewed Feb 14, 2022
View reviewed changes
docs/guides/building-forms.md Outdated Show resolved Hide resolved
ijjk
ijjk approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit c0c11ad into vercel:canary Feb 14, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@T-O-R-U-S @ijjk