Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example to Write server-side code directly section #34319

Merged
merged 4 commits into from Feb 14, 2022
Merged

Add an example to Write server-side code directly section #34319

merged 4 commits into from Feb 14, 2022

Conversation

amandeepmittal
Copy link
Contributor

@amandeepmittal amandeepmittal commented Feb 14, 2022 •
edited

In addition to https://github.com/vercel/front/pull/12473, this PR adds an example to the section :Write server-side code directly.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@amandeepmittal amandeepmittal added the created-by: Next.js docs team PRs by the Next.js docs team label Feb 14, 2022
@amandeepmittal
Copy link
Contributor Author

amandeepmittal commented Feb 14, 2022 •
edited

@ijjk, made an update to the example. Please have a look 🙏

ijjk
ijjk approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kodiakhq kodiakhq bot merged commit d9eba57 into vercel:canary Feb 14, 2022
@amandeepmittal amandeepmittal deleted the add-example-to-write-server-side-code-section branch February 14, 2022 19:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
created-by: Next.js docs team PRs by the Next.js docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amandeepmittal @ijjk