Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align reactRoot config between server and webpack config #34328

Merged
merged 3 commits into from Feb 14, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 14, 2022

Changes

  • node server and webpack should share the same logic: auto detect react 18 and enable reactRoot
  • fallback _error should use functional document if concurrent rendering is enabled

Test

  • Remove the hard code reactRoot: true in test suite
  • Test some react-18 test suite with nodejs runtime

@ijjk

This comment has been minimized.

@huozhi huozhi requested a review from shuding February 14, 2022 15:45
@ijjk
Copy link
Member

ijjk commented Feb 14, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js align-react-root Change
buildDuration 14.9s 14.9s ⚠️ +10ms
buildDurationCached 5.9s 6s ⚠️ +51ms
nodeModulesSize 359 MB 359 MB ⚠️ +791 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js align-react-root Change
/ failed reqs 0 0
/ total time (seconds) 2.982 2.99 ⚠️ +0.01
/ avg req/sec 838.25 836.22 ⚠️ -2.03
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.149 1.172 ⚠️ +0.02
/error-in-render avg req/sec 2175.77 2133.03 ⚠️ -42.74
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js align-react-root Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js align-react-root Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js align-react-root Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js align-react-root Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js align-react-root Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js align-react-root Change
buildDuration 18.7s 18.4s -355ms
buildDurationCached 6.1s 6.2s ⚠️ +102ms
nodeModulesSize 359 MB 359 MB ⚠️ +791 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js align-react-root Change
/ failed reqs 0 0
/ total time (seconds) 3.022 2.994 -0.03
/ avg req/sec 827.17 835.06 +7.89
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.156 1.153 0
/error-in-render avg req/sec 2162.94 2168.96 +6.02
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js align-react-root Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js align-react-root Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js align-react-root Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js align-react-root Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js align-react-root Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 90aa826

@kodiakhq kodiakhq bot merged commit 1aee935 into canary Feb 14, 2022
@kodiakhq kodiakhq bot deleted the align-react-root branch February 14, 2022 16:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants