Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next-swc): Update swc #34355

Merged
merged 18 commits into from Feb 15, 2022
Merged

feat(next-swc): Update swc #34355

merged 18 commits into from Feb 15, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 15, 2022

This update swc crates to

swc-project/swc@a5b3dd8

from

swc-project/swc@3b7e594

Note that swc does not hoist imports anymore, as runtime will hoist it anyway.


@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 15, 2022
@kdy1 kdy1 marked this pull request as draft February 15, 2022 03:59
@ijjk

This comment has been minimized.

@kdy1 kdy1 marked this pull request as ready for review February 15, 2022 04:33
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@Brooooooklyn
Copy link
Contributor

I think I can finally update NAPI-RS to v2 after this is merged.

@ijjk
Copy link
Member

ijjk commented Feb 15, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-v-1 Change
buildDuration 15.6s 15.6s ⚠️ +13ms
buildDurationCached 6.1s 6.1s -7ms
nodeModulesSize 367 MB 367 MB ⚠️ +7 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-v-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.165 3.184 ⚠️ +0.02
/ avg req/sec 789.8 785.3 ⚠️ -4.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.342 1.33 -0.01
/error-in-render avg req/sec 1862.45 1880.16 +17.71
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-v-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-v-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-v-1 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-v-1 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-v-1 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-v-1 Change
buildDuration 19.2s 19.2s ⚠️ +17ms
buildDurationCached 6.2s 6.1s -58ms
nodeModulesSize 367 MB 367 MB ⚠️ +7 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-v-1 Change
/ failed reqs 0 0
/ total time (seconds) 3.213 3.227 ⚠️ +0.01
/ avg req/sec 777.98 774.6 ⚠️ -3.38
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.379 1.369 -0.01
/error-in-render avg req/sec 1813.36 1826.3 +12.94
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-v-1 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-v-1 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-v-1 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-v-1 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-v-1 Change
index.html gzip 533 B 533 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: f214d49

@kodiakhq kodiakhq bot merged commit 4500cb7 into vercel:canary Feb 15, 2022
ijjk added a commit to ijjk/next.js that referenced this pull request Feb 16, 2022
kodiakhq bot pushed a commit that referenced this pull request Feb 16, 2022
This reverts the below two swc crates bumps to unblock testing changes while an issue with `styled-jsx` interpolation is investigated, we can reland after that issue is addressed. 

Reverts #34408
Reverts #34355

x-ref: [slack thread](https://vercel.slack.com/archives/C02HY34AKME/p1645032079994029)
@ijjk ijjk mentioned this pull request Feb 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
@kdy1 kdy1 deleted the swc-v-1 branch March 30, 2022 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@media print styles are applied to regular view
3 participants