Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated failed to load error page to include info about node versions #34362

Merged
merged 3 commits into from Feb 15, 2022
Merged

Updated failed to load error page to include info about node versions #34362

merged 3 commits into from Feb 15, 2022

Conversation

molebox
Copy link
Contributor

@molebox molebox commented Feb 15, 2022

This PR updates the failed loading swc error page with information about switching node version and installing deps again.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

ijjk
ijjk reviewed Feb 15, 2022
View reviewed changes
errors/failed-loading-swc.md Outdated Show resolved Hide resolved
@molebox @ijjk
Update errors/failed-loading-swc.md
e621e7c 
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@molebox molebox requested a review from ijjk February 15, 2022 15:37
@kodiakhq kodiakhq bot merged commit 127f94d into vercel:canary Feb 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
created-by: Next.js docs team PRs by the Next.js docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@molebox @ijjk