Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add inline flight response reuse test #34364

Merged
merged 7 commits into from Feb 15, 2022

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Feb 15, 2022

To collect the requests starting from page load, we need to register event listeners before page loading (page.goto API invocation). By default webdriver will wait for hydration, so we need to register events inside browser.loadPage to ensure we can collect the requests before hydration is done.

Changes

  • Add beforePageLoad for next webdriver
  • registry page 'request' event before loading page
  • update related tests for agruments change

Usage

browser = await webdriver(appPort, '/path', {
   waitHydration, // default true
   retryWaitHydration, // default false
   disableCache, // default false
   beforePageLoad, // default undefined
})

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Feb 15, 2022
@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as draft February 15, 2022 14:03
@huozhi huozhi requested a review from shuding February 15, 2022 14:40
@huozhi huozhi marked this pull request as ready for review February 15, 2022 14:40
@huozhi huozhi requested a review from styfle as a code owner February 15, 2022 14:40
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Feb 15, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js test/inline-response Change
buildDuration 15.3s 15.5s ⚠️ +192ms
buildDurationCached 6s 6.1s ⚠️ +64ms
nodeModulesSize 367 MB 367 MB ⚠️ +5 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js test/inline-response Change
/ failed reqs 0 0
/ total time (seconds) 3.137 3.12 -0.02
/ avg req/sec 796.97 801.37 +4.4
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.328 1.315 -0.01
/error-in-render avg req/sec 1882.88 1901.67 +18.79
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js test/inline-response Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/inline-response Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/inline-response Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/inline-response Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/inline-response Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js test/inline-response Change
buildDuration 18.8s 18.9s ⚠️ +88ms
buildDurationCached 6s 6.1s ⚠️ +41ms
nodeModulesSize 367 MB 367 MB ⚠️ +5 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js test/inline-response Change
/ failed reqs 0 0
/ total time (seconds) 3.146 3.119 -0.03
/ avg req/sec 794.73 801.57 +6.84
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.347 1.326 -0.02
/error-in-render avg req/sec 1855.31 1884.78 +29.47
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js test/inline-response Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js test/inline-response Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js test/inline-response Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js test/inline-response Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js test/inline-response Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: 2081257

@kodiakhq kodiakhq bot merged commit 00ca8df into vercel:canary Feb 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants