Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(next-swc): Update swc #34408

Merged
merged 1 commit into from Feb 16, 2022
Merged

feat(next-swc): Update swc #34408

merged 1 commit into from Feb 16, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 16, 2022

This fixes wrong lint for overloads with export default

@ijjk
Copy link
Member

ijjk commented Feb 16, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-v-2 Change
buildDuration 21.1s 21.2s ⚠️ +95ms
buildDurationCached 8.2s 8s -212ms
nodeModulesSize 368 MB 368 MB -1 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-v-2 Change
/ failed reqs 0 0
/ total time (seconds) 4.589 4.574 -0.02
/ avg req/sec 544.77 546.59 +1.82
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.246 2.281 ⚠️ +0.04
/error-in-render avg req/sec 1113.2 1096.25 ⚠️ -16.95
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-v-2 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-v-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-v-2 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.01 kB 5.01 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-v-2 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-v-2 Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary kdy1/next.js swc-v-2 Change
buildDuration 25.6s 25.6s -36ms
buildDurationCached 8s 7.9s -43ms
nodeModulesSize 368 MB 368 MB -1 B
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-v-2 Change
/ failed reqs 0 0
/ total time (seconds) 4.592 4.519 -0.07
/ avg req/sec 544.4 553.18 +8.78
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.314 2.269 -0.04
/error-in-render avg req/sec 1080.23 1101.7 +21.47
Client Bundles (main, webpack, commons)
vercel/next.js canary kdy1/next.js swc-v-2 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-v-2 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-v-2 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-v-2 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-v-2 Change
index.html gzip 533 B 533 B
link.html gzip 548 B 548 B
withRouter.html gzip 529 B 529 B
Overall change 1.61 kB 1.61 kB
Commit: 8bee4b7

@kodiakhq kodiakhq bot merged commit 73581f3 into vercel:canary Feb 16, 2022
ijjk added a commit to ijjk/next.js that referenced this pull request Feb 16, 2022
kodiakhq bot pushed a commit that referenced this pull request Feb 16, 2022
This reverts the below two swc crates bumps to unblock testing changes while an issue with `styled-jsx` interpolation is investigated, we can reland after that issue is addressed. 

Reverts #34408
Reverts #34355

x-ref: [slack thread](https://vercel.slack.com/archives/C02HY34AKME/p1645032079994029)
@ijjk ijjk mentioned this pull request Feb 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2022
@kdy1 kdy1 deleted the swc-v-2 branch March 30, 2022 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants