Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert swc css bump temporarily #34440

Merged
merged 3 commits into from Feb 16, 2022
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 16, 2022

This reverts the below two swc crates bumps to unblock testing changes while an issue with styled-jsx interpolation is investigated, we can reland after that issue is addressed.

Reverts #34408
Reverts #34355

x-ref: slack thread

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 16, 2022
@ijjk ijjk marked this pull request as ready for review February 16, 2022 19:16
@ijjk ijjk requested review from kdy1 and styfle February 16, 2022 19:16
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member Author

ijjk commented Feb 16, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
buildDuration 18.6s 18.6s -5ms
buildDurationCached 7.3s 7.3s ⚠️ +18ms
nodeModulesSize 359 MB 359 MB -1 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
/ failed reqs 0 0
/ total time (seconds) 3.791 3.797 ⚠️ +0.01
/ avg req/sec 659.4 658.39 ⚠️ -1.01
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.629 1.656 ⚠️ +0.03
/error-in-render avg req/sec 1535.14 1509.52 ⚠️ -25.62
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.04 kB 5.04 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
index.html gzip 532 B 532 B
link.html gzip 545 B 545 B
withRouter.html gzip 527 B 527 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
buildDuration 22.2s 22.2s ⚠️ +78ms
buildDurationCached 7.2s 7.3s ⚠️ +113ms
nodeModulesSize 359 MB 359 MB -1 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
/ failed reqs 0 0
/ total time (seconds) 3.802 3.779 -0.02
/ avg req/sec 657.53 661.59 +4.06
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.599 1.628 ⚠️ +0.03
/error-in-render avg req/sec 1563.85 1535.69 ⚠️ -28.16
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js revert/swc-css-bump Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 96c35b7

@kodiakhq kodiakhq bot merged commit 01524ef into vercel:canary Feb 16, 2022
@ijjk ijjk deleted the revert/swc-css-bump branch February 17, 2022 18:02
ijjk added a commit that referenced this pull request Feb 17, 2022
@ijjk ijjk mentioned this pull request Feb 17, 2022
ijjk added a commit that referenced this pull request Feb 18, 2022
* Revert "Revert swc css bump temporarily (#34440)"

This reverts commit 01524ef.

* Update css crates

Co-authored-by: Donny/강동윤 <kdy1997.dev@gmail.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants