Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify .env.local gitignores #34471

Merged
merged 6 commits into from Feb 18, 2022
Merged

Simplify .env.local gitignores #34471

merged 6 commits into from Feb 18, 2022

Conversation

ephraimduncan
Copy link
Contributor

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Feb 17, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, and thanks! We wouldn't want to ignore all .env files, only those that end with .local.

As per our docs, you could change it to .env*.local instead: https://nextjs.org/docs/basic-features/environment-variables#default-environment-variables

ephraimduncan and others added 2 commits February 18, 2022 14:33
Co-authored-by: Balázs Orbán <info@balazsorban.com>
Co-authored-by: Balázs Orbán <info@balazsorban.com>
@ijjk ijjk changed the title ignoring all .env files Simplify .env.local gitignores Feb 18, 2022
@ijjk
Copy link
Member

ijjk commented Feb 18, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary dephraiim/next.js canary Change
buildDuration 15.8s 15.6s -175ms
buildDurationCached 6.3s 6.1s -122ms
nodeModulesSize 367 MB 367 MB ⚠️ +14 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary dephraiim/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 2.981 2.932 -0.05
/ avg req/sec 838.55 852.57 +14.02
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.351 1.382 ⚠️ +0.03
/error-in-render avg req/sec 1850.68 1809.05 ⚠️ -41.63
Client Bundles (main, webpack, commons)
vercel/next.js canary dephraiim/next.js canary Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary dephraiim/next.js canary Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary dephraiim/next.js canary Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary dephraiim/next.js canary Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary dephraiim/next.js canary Change
index.html gzip 532 B 532 B
link.html gzip 544 B 544 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary dephraiim/next.js canary Change
buildDuration 19s 19.4s ⚠️ +334ms
buildDurationCached 6.3s 6.1s -250ms
nodeModulesSize 367 MB 367 MB ⚠️ +14 B
Page Load Tests Overall increase ✓
vercel/next.js canary dephraiim/next.js canary Change
/ failed reqs 0 0
/ total time (seconds) 3.003 2.975 -0.03
/ avg req/sec 832.51 840.23 +7.72
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.38 1.359 -0.02
/error-in-render avg req/sec 1811.92 1839.22 +27.3
Client Bundles (main, webpack, commons)
vercel/next.js canary dephraiim/next.js canary Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.9 kB 27.9 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.7 kB 71.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary dephraiim/next.js canary Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary dephraiim/next.js canary Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary dephraiim/next.js canary Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary dephraiim/next.js canary Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB
Commit: b109737

@ijjk ijjk merged commit 2c80444 into vercel:canary Feb 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants