Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 404 links in React 18 docs #34486

Merged
merged 1 commit into from Feb 17, 2022
Merged

Fix 404 links in React 18 docs #34486

merged 1 commit into from Feb 17, 2022
+2 −2

Conversation

shuding
Copy link
Member

@shuding shuding commented Feb 17, 2022 •
edited

https://nextjs.org/docs/advanced-features/react-18/overview

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@kodiakhq kodiakhq bot merged commit ae3e55d into canary Feb 17, 2022
@kodiakhq kodiakhq bot deleted the shuding-patch-1 branch February 17, 2022 16:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@leerob leerob leerob approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@styfle styfle Awaiting requested review from styfle

@padmaia padmaia Awaiting requested review from padmaia

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shuding @huozhi @leerob @ijjk