Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info on rendering an error page when using getServerSideProps #34488

Merged
merged 6 commits into from Feb 17, 2022
Merged

Add info on rendering an error page when using getServerSideProps #34488

merged 6 commits into from Feb 17, 2022

Conversation

amandeepmittal
Copy link
Contributor

This PR adds information on rendering an error page (500 page specifically) when using getServerSideProps.

Bug

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@amandeepmittal amandeepmittal added the created-by: Next.js docs team PRs by the Next.js docs team label Feb 17, 2022
amandeepmittal and others added 4 commits February 17, 2022 23:58
@amandeepmittal @ijjk
Update docs/basic-features/data-fetching/get-server-side-props.md
a0197d4 
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@ijjk
Merge branch 'canary' into update-getserversideprops-doc
890f7ab 
# Conflicts:
#	docs/basic-features/data-fetching/get-server-side-props.md
@ijjk
lint-fix
0ffccfc
@ijjk
re-add note
edbcc26
@kodiakhq kodiakhq bot merged commit 787186a into vercel:canary Feb 17, 2022
@amandeepmittal amandeepmittal deleted the update-getserversideprops-doc branch February 18, 2022 04:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

@molebox molebox Awaiting requested review from molebox

Assignees
No one assigned
Labels
created-by: Next.js docs team PRs by the Next.js docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amandeepmittal @ijjk