New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert custom-server-hapi Example to Typescript #34507
Merged
kodiakhq
merged 9 commits into
vercel:canary
from
mitchell-abbott:convert-custom-hapi-server-typescript
Feb 18, 2022
Merged
Convert custom-server-hapi Example to Typescript #34507
kodiakhq
merged 9 commits into
vercel:canary
from
mitchell-abbott:convert-custom-hapi-server-typescript
Feb 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell-abbott
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey and
huozhi
as code owners
February 18, 2022 03:37
mitchell-abbott
changed the title
Convert custom hapi server typescript
Convert custom-server-hapi Example to Typescript
Feb 18, 2022
leerob
previously approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I went ahead an ran the actions on my fork to ensure that the line endings issue wouldn't be an issue again to avoid wasting the action time for the project. Will do that for future PRs before I make them as well as a safety measure. |
leerob
approved these changes
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the contributing doc, it mentions "Examples should be TypeScript first, if possible" so I thought about converting some examples to be typescript along with updating a couple in my free time. Let me know if that would be an issue.
Bug
fixes #number
contributing.md
Feature
fixes #number
contributing.md
Documentation / Examples
yarn lint