Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert custom-server-hapi Example to Typescript #34507

Merged
merged 9 commits into from Feb 18, 2022
Merged

Convert custom-server-hapi Example to Typescript #34507

merged 9 commits into from Feb 18, 2022

Conversation

mitchell-abbott
Copy link
Contributor

In the contributing doc, it mentions "Examples should be TypeScript first, if possible" so I thought about converting some examples to be typescript along with updating a couple in my free time. Let me know if that would be an issue.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label Feb 18, 2022
@mitchell-abbott mitchell-abbott changed the title Convert custom hapi server typescript Convert custom-server-hapi Example to Typescript Feb 18, 2022
leerob
leerob previously approved these changes Feb 18, 2022
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mitchell-abbott
Copy link
Contributor Author

I went ahead an ran the actions on my fork to ensure that the line endings issue wouldn't be an issue again to avoid wasting the action time for the project. Will do that for future PRs before I make them as well as a safety measure.

Test Build Actions PR
image

@kodiakhq kodiakhq bot merged commit 670eb03 into vercel:canary Feb 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants