example: with-mantine #34591
Merged
example: with-mantine #34591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nip10
requested review from
timneutkens,
ijjk,
shuding,
leerob and
steven-tey
as code owners
examples/with-mantine/.gitignore
Outdated
Comment on lines
26
to
35
| .pnpm-debug.log* | ||
|
|
||
| # local env files | ||
| .env*.local | ||
| .env.local | ||
| .env.development.local | ||
| .env.test.local | ||
| .env.production.local | ||
|
|
||
| # vercel | ||
| .vercel | ||
|
|
||
| # typescript | ||
| *.tsbuildinfo |
There was a problem hiding this comment.
This file looks already correct to me.
examples/with-mantine/README.md
Outdated
Comment on lines
3
to
13
| This is a simple project that shows the usage of Next.js with TypeScript and Mantine. | ||
| This example features how you use [mantine](https://github.com/mantine/mantine), a React component library. | ||
|
|
||
| ## Preview | ||
|
|
||
| Preview the example live on [StackBlitz](http://stackblitz.com/): | ||
|
|
||
| [](https://stackblitz.com/github/vercel/next.js/tree/canary/examples/with-mantine) | ||
|
|
||
| ## Deploy your own | ||
|
|
||
| Deploy the example using [Vercel](https://vercel.com?utm_source=github&utm_medium=readme&utm_campaign=next-example) or preview live with [StackBlitz](https://stackblitz.com/github/vercel/next.js/tree/canary/examples/with-typescript-mantine) | ||
| Deploy the example using [Vercel](https://vercel.com?utm_source=github&utm_medium=readme&utm_campaign=next-example): |
There was a problem hiding this comment.
This should not change, to align with the other examples
examples/with-mantine/README.md
Outdated
Comment on lines
19
to
31
| # or | ||
| pnpm create next-app -- --example with-mantine with-mantine-app | ||
| ``` | ||
|
|
||
| Deploy it to the cloud with [Vercel](https://vercel.com/new?utm_source=github&utm_medium=readme&utm_campaign=next-example) ([Documentation](https://nextjs.org/docs/deployment)). | ||
|
|
||
| ### Try it on CodeSandbox | ||
|
|
||
| [Open this example on CodeSandbox](https://codesandbox.io/s/github/vercel/next.js/tree/canary/examples/with-mantine) |
There was a problem hiding this comment.
This should not change to align with the other examples.
examples/with-mantine/pages/_app.js
Outdated
| @@ -0,0 +1,26 @@ | |||
| import Head from 'next/head'; | |||
There was a problem hiding this comment.
There is already a _app.tsx file
| @@ -0,0 +1,8 @@ | |||
| import Document from 'next/document'; | |||
There was a problem hiding this comment.
There is already a _document.tsx file
examples/with-mantine/pages/index.js
Outdated
| @@ -0,0 +1,22 @@ | |||
| import { Title, Text, Anchor } from '@mantine/core'; | |||
There was a problem hiding this comment.
There is already a index.tsx file
balazsorban44
requested changes
May 2, 2022
There was a problem hiding this comment.
Thanks, but there was already a with-mantine example present, therefore some of these changes here are unnecessary.
See the original PR: #36294
balazsorban44
approved these changes
Sep 30, 2022
BowlingX
pushed a commit
to BowlingX/next.js
that referenced
this pull request
Oct 5, 2022
[Mantine ](https://mantine.dev/) is a fully featured React components library. This PR adds an example of Mantine + Next.js ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint` Co-authored-by: Balázs Orbán <info@balazsorban.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mantine is a fully featured React components library.
This PR adds an example of Mantine + Next.js
Documentation / Examples
yarn lint