Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates with-supertokens example #34679

Merged
merged 106 commits into from Feb 22, 2022
Merged

Updates with-supertokens example #34679

merged 106 commits into from Feb 22, 2022

Conversation

rishabhpoddar
Copy link
Contributor

Updates supertokens-node dependency to use the latest released version

NkxxkN and others added 30 commits February 16, 2021 15:21
add-supertokens-to-authentication.md
7e044a9
Merge branch 'canary' into with-supertokens-example-in-docs
8e5bd92
@kant01ne
bump supertokens deps
e290993
@kant01ne
update SuperTokens Auth doc
0fecb52
Merge branch 'canary' into with-supertokens-example-in-docs
055047b
@leerob
Update docs/authentication.md
49caedd 
Co-authored-by: Lee Robinson <me@leerob.io>
@leerob
Update docs/authentication.md
a00f6a5 
Co-authored-by: Lee Robinson <me@leerob.io>
@rishabhpoddar
updates supertokens dependency and optimises for serverless execution
fa05b78
@rishabhpoddar
updates with original repo
0af47ee
@rishabhpoddar
runs prettier-fix
feab6fb
@rishabhpoddar
Merge branch 'canary' into canary
5d8c319
@rishabhpoddar
adds supertokens to 'Bring Your Own Database' section as well
7a50823
@rishabhpoddar
Merge branch 'canary' into canary
05795a5
@rishabhpoddar
does not show home page if not logged in
b44c159
@rishabhpoddar
extracts config into its own file and calls it in all serverless func…
ca44249 
…tions
@rishabhpoddar
removes need for backend init in app.jsx
13ad8f2
@rishabhpoddar
simplifies use of dynamic
83a8369
@rishabhpoddar
Merge branch 'canary' into canary
88f9193
@rishabhpoddar
refreshes page after getServerSideProps
39a850e
@rishabhpoddar
removes unnecessary check in API
1007e80
@rishabhpoddar
Merge branch 'canary' into canary
d0c8a19
@rishabhpoddar
update to docs pertaining SuperTokens
6f05b35
@rishabhpoddar
adds placeholder secrets so that the UI loads on first run
80e72e9
@rishabhpoddar
changes to readme
bbf27a2
@rishabhpoddar
updates version of supertokens frontend and backend SDK, and a few ot…
52e423b 
…her fixes
@rishabhpoddar
Merge branch 'canary' into canary
93b6588
@rishabhpoddar @leerob
Update docs/authentication.md
c88554b 
Co-authored-by: Lee Robinson <me@leerob.io>
@rishabhpoddar
Merge branch 'canary' into canary
121c5ae
@rishabhpoddar
Merge branch 'canary' into canary
3f8906b
@rishabhpoddar
updates to readme for supertokens example
5c7bf78
@ijjk ijjk added the examples Issue/PR related to examples label Feb 22, 2022
@rishabhpoddar rishabhpoddar marked this pull request as ready for review February 22, 2022 10:13
balazsorban44
balazsorban44 reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we bump all the dependencies and devDependencies as a house cleaning step?

@rishabhpoddar
Copy link
Contributor Author

@balazsorban44

  • i added a ^ to the react dependency which should fetch the latest version for react anyone installing it now.
  • I updated the dev dependency to the latest version with a ^ too.
  • As for the other dependencies, they all have a ^ anyway and they will fetch the latest versions.

Is this what you wanted?

balazsorban44
balazsorban44 reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, let's get rid of devDependencies altogether, as ESLint isn't used in this example.

@rishabhpoddar
Copy link
Contributor Author

Actually, let's get rid of devDependencies altogether, as ESLint isn't used in this example.

Done.

@ijjk ijjk merged commit 037f79d into vercel:canary Feb 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rishabhpoddar @balazsorban44 @ijjk @kant01ne @bhumilsarvaiya @jscyo