Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS to include renamed files #34686

Merged
merged 3 commits into from Feb 22, 2022

Conversation

styfle
Copy link
Member

@styfle styfle commented Feb 22, 2022

balazsorban44
balazsorban44 previously approved these changes Feb 22, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a glob like **/*image* might be more future proof but this looks good for now.

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all the lines that are covered by the wildcard?

@ijjk
Copy link
Member

ijjk commented Feb 22, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
buildDuration 15.3s 15.5s ⚠️ +256ms
buildDurationCached 6.1s 6.1s -75ms
nodeModulesSize 367 MB 367 MB -5 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
/ failed reqs 0 0
/ total time (seconds) 2.945 2.921 -0.02
/ avg req/sec 849.04 855.79 +6.75
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.327 1.328 0
/error-in-render avg req/sec 1883.87 1883.21 ⚠️ -0.66
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.5 kB 71.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.57 kB 2.57 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 5.05 kB 5.05 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.26 kB 2.26 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
buildDuration 19s 18.8s -155ms
buildDurationCached 6.1s 6s -100ms
nodeModulesSize 367 MB 367 MB -5 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
/ failed reqs 0 0
/ total time (seconds) 2.938 2.964 ⚠️ +0.03
/ avg req/sec 850.78 843.44 ⚠️ -7.34
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.345 1.367 ⚠️ +0.02
/error-in-render avg req/sec 1858.42 1828.87 ⚠️ -29.55
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.1 kB 42.1 kB
main-HASH.js gzip 27.8 kB 27.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.6 kB 71.6 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.56 kB 2.56 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 5.08 kB 5.08 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.28 kB 2.28 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.7 kB 14.7 kB
Client Build Manifests
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js codeowners-styfle-image Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 05de036

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@balazsorban44 balazsorban44 merged commit ea532c7 into canary Feb 22, 2022
@balazsorban44 balazsorban44 deleted the codeowners-styfle-image branch February 22, 2022 15:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants