Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert with-redis example to TypeScript #34720

Merged
merged 9 commits into from Feb 23, 2022
Merged

Convert with-redis example to TypeScript #34720

merged 9 commits into from Feb 23, 2022

Conversation

brodyd795
Copy link
Contributor

@brodyd795 brodyd795 commented Feb 23, 2022 •
edited

With the recent push to get the examples in TypeScript, I thought I'd convert this with-redis example over.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label Feb 23, 2022
@brodyd795 brodyd795 marked this pull request as ready for review February 23, 2022 13:06
@brodyd795 brodyd795 changed the title With redis typescript Convert with-redis example to TypeScript Feb 23, 2022
@brodyd795
Copy link
Contributor Author

Got all the actions passing on my own fork!

image

leerob
leerob approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kodiakhq kodiakhq bot merged commit 33d9615 into vercel:canary Feb 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brodyd795 @leerob @ijjk