Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router.asPath contains dynamic path as query params in non default language on vercel. #34804

Closed
1 task done
akshitkrnagpal opened this issue Feb 25, 2022 · 6 comments
Closed
1 task done
Labels
bug Issue was opened via the bug report template. Internationalization (i18n) Related to Internationalization with Next.js. Navigation Related to Next.js linking (e.g., <Link>) and navigation. please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity

Comments

@akshitkrnagpal
Copy link

akshitkrnagpal commented Feb 25, 2022

Verify canary release

  • I verified that the issue exists in Next.js canary release

Provide environment information

    Operating System:
      Platform: darwin
      Arch: x64
      Version: Darwin Kernel Version 21.1.0: Wed Oct 13 17:33:01 PDT 2021; root:xnu-8019.41.5~1/RELEASE_ARM64_T6000
    Binaries:
      Node: 14.18.1
      npm: 6.14.15
      Yarn: 1.22.17
      pnpm: N/A
    Relevant packages:
      next: 12.1.1-canary.2
      react: 17.0.2
      react-dom: 17.0.2

What browser are you using? (if relevant)

No response

How are you deploying your application? (if relevant)

Vercel

Describe the Bug

router.asPath contains dynamic path as query params in non default language on vercel.

Example -
Assume there is a page [...search].js.

For path /my-path, router.asPath returns /my-path on server and /my-path on client.
For path /nl/my-path, router.asPath returns /nl/my-path?search=my-path on server and /my-path on client.

Only happens for non-default locale.
Only happens on vercel.

Expected Behavior

For path /nl/my-path, router.asPath returns /my-path

To Reproduce

See the implementation here.
https://github.com/akshitkrnagpal/vercel-as-path-issue

  1. Go to page https://vercel-as-path-issue.vercel.app/nl/my-path

  2. You will see asPath as /my-path

image

  1. Do view source. You will see different asPath in html. See image below.

image

@akshitkrnagpal akshitkrnagpal added the bug Issue was opened via the bug report template. label Feb 25, 2022
@xhoantran
Copy link
Contributor

I believe you should use router.isReady prop in this situation. Check this pull request

@akshitkrnagpal
Copy link
Author

@xhoantran This isn't ideal solution. I want this to be crawlable by bots and and this leads to crawler's going to incorrect urls. Please suggest what can be done to make it correct on server.

@ThePeterMick
Copy link

ThePeterMick commented Mar 15, 2022

I've also noticed that when you use router.asPath for og:url then the homepage (/) will appear as "/index" - only on Vercel, export on Cloudflare Pages doesn't do that.

I wonder if it also affects locales? I suspect it'd end up looking like /index/nl or /nl/index or...?

(12.1.0)

Edit: I've now raised a bug for it #35345

@balazsorban44 balazsorban44 added Navigation Related to Next.js linking (e.g., <Link>) and navigation. Internationalization (i18n) Related to Internationalization with Next.js. labels Mar 16, 2022
@jankaifer jankaifer added the please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity label Jan 12, 2023
@github-actions
Copy link
Contributor

Please verify that your issue can be recreated with next@canary.

Why was this issue marked with the please verify canary label?

We noticed the provided reproduction was using an older version of Next.js, instead of canary.

The canary version of Next.js ships daily and includes all features and fixes that have not been released to the stable version yet. You can think of canary as a public beta. Some issues may already be fixed in the canary version, so please verify that your issue reproduces by running npm install next@canary and test it in your project, using your reproduction steps.

If the issue does not reproduce with the canary version, then it has already been fixed and this issue can be closed.

How can I quickly verify if my issue has been fixed in canary?

The safest way is to install next@canary in your project and test it, but you can also search through closed Next.js issues for duplicates or check the Next.js releases. You can also use the GitHub template (preferred), or the CodeSandbox or StackBlitz templates to create a reproduction with canary from scratch.

My issue has been open for a long time, why do I need to verify canary now?

Next.js does not backport bug fixes to older versions of Next.js. Instead, we are trying to introduce only a minimal amount of breaking changes between major releases.

What happens if I don't verify against the canary version of Next.js?

An issue with the please verify canary that receives no meaningful activity (e.g. new comments that acknowledge verification against canary) will be automatically closed and locked after 30 days.

If your issue has not been resolved in that time and it has been closed/locked, please open a new issue, with the required reproduction, using next@canary.

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps. Furthermore, you can upvote the issue using the 👍 reaction on the topmost comment (please do not comment "I have the same issue" without repro steps). Then, we can sort issues by votes to prioritize.

I think my reproduction is good enough, why aren't you looking into it quicker?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@balazsorban44
Copy link
Member

This issue has been automatically closed because it wasn't verified against next@canary. If you think it was closed by accident, please leave a comment. If you are running into a similar issue, please open a new issue with a reproduction. Thank you.

@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. Internationalization (i18n) Related to Internationalization with Next.js. Navigation Related to Next.js linking (e.g., <Link>) and navigation. please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity
Projects
None yet
Development

No branches or pull requests

5 participants