Simplify next-flight-server-loader

[huozhi]

• merge logic of client component detection
• remove beginPos since it's always 0 now in new version of swc parser

[ijjk]

Failing test suites

Commit: afa66b3

yarn testheadless test/production/middleware-typescript/test/index.test.ts

• should set-up next > should have built and started

Expand output

● should set-up next › should have built and started

thrown: "Exceeded timeout of 90000 ms for a hook.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  11 |   let next: NextInstance
  12 |
> 13 |   beforeAll(async () => {
     |   ^
  14 |     next = await createNext({
  15 |       files: {
  16 |         pages: new FileRef(join(appDir, 'pages')),

  at production/middleware-typescript/test/index.test.ts:13:3
  at Object.<anonymous> (production/middleware-typescript/test/index.test.ts:10:1)

● Test suite failed to run

TypeError: Cannot read property 'destroy' of undefined

  26 |     })
  27 |   })
> 28 |   afterAll(() => next.destroy())
     |                       ^
  29 |
  30 |   it('should have built and started', async () => {
  31 |     const html = await renderViaHTTP(next.url, '/interface/static')

  at production/middleware-typescript/test/index.test.ts:28:23

Read more about building and testing Next.js in contributing.md.

[ijjk]

Stats from current PR

Default Build (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
buildDuration	15.4s	15.2s	-184ms
buildDurationCached	6.2s	6.2s	⚠️ +58ms
nodeModulesSize	368 MB	368 MB	⚠️ +48 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.93	2.902	-0.03
/ avg req/sec	853.28	861.47	+8.19
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.174	1.146	-0.03
/error-in-render avg req/sec	2129.32	2182.28	+52.96

Client Bundles (main, webpack)

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	27.9 kB	27.9 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.5 kB	71.5 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
_app-HASH.js gzip	1.36 kB	1.36 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.57 kB	2.57 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	5.05 kB	5.05 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.26 kB	2.26 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.7 kB	14.7 kB	✓

Client Build Manifests

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
index.html gzip	531 B	531 B	✓
link.html gzip	544 B	544 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

---

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
buildDuration	18.8s	18.9s	⚠️ +92ms
buildDurationCached	6.1s	6.2s	⚠️ +146ms
nodeModulesSize	368 MB	368 MB	⚠️ +48 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.921	2.907	-0.01
/ avg req/sec	855.93	859.92	+3.99
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.146	1.16	⚠️ +0.01
/error-in-render avg req/sec	2181.6	2155.05	⚠️ -26.55

Client Bundles (main, webpack)

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.1 kB	42.1 kB	✓
main-HASH.js gzip	27.9 kB	27.9 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.6 kB	71.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.56 kB	2.56 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	911 B	911 B	✓
image-HASH.js gzip	5.09 kB	5.09 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.28 kB	2.28 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.7 kB	14.7 kB	✓

Client Build Manifests

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
_buildManifest.js gzip	458 B	458 B	✓
Overall change	458 B	458 B	✓

Rendered Page Sizes

	vercel/next.js canary	huozhi/next.js refactor/rsc-loader	Change
index.html gzip	532 B	532 B	✓
link.html gzip	546 B	546 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: e5d01c5