Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples/with-docker): add npm comment for yarn build #35040

Merged
merged 1 commit into from Mar 4, 2022
Merged

fix(examples/with-docker): add npm comment for yarn build #35040

merged 1 commit into from Mar 4, 2022

Conversation

midgleyc
Copy link
Contributor

@midgleyc midgleyc commented Mar 4, 2022

There was an npm equivalent for yarn install (npm ci) but not one for yarn build. I've added npm run build as a commented out option.

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label Mar 4, 2022
@kodiakhq kodiakhq bot merged commit 946f465 into vercel:canary Mar 4, 2022
@midgleyc midgleyc deleted the with-docker-npm-comment branch March 4, 2022 18:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leerob leerob leerob approved these changes

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@midgleyc @leerob @ijjk