Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Add Tina CMS blog starter #35045

Merged
merged 11 commits into from Mar 5, 2022
Merged

[examples] Add Tina CMS blog starter #35045

merged 11 commits into from Mar 5, 2022

Conversation

perkinsjr
Copy link
Contributor

Documentation / Examples

  • Adding TInaCMS example using the traditional CMS example

@ijjk ijjk added the examples Issue/PR related to examples label Mar 4, 2022
examples/cms-tina/.tina/schema.ts Outdated Show resolved Hide resolved
examples/cms-tina/components/avatar.js Outdated Show resolved Hide resolved
examples/cms-tina/components/cover-image.js Outdated Show resolved Hide resolved
examples/cms-tina/components/hero-post.js Outdated Show resolved Hide resolved
examples/cms-tina/content/posts/HelloWorld.md Outdated Show resolved Hide resolved
examples/cms-tina/package.json Outdated Show resolved Hide resolved
@perkinsjr
Copy link
Contributor Author

Added the changes requested, and fix the Next starter

@perkinsjr perkinsjr requested a review from leerob March 4, 2022 17:40
examples/blog-starter/components/avatar.js Outdated Show resolved Hide resolved
examples/cms-tina/components/avatar.js Outdated Show resolved Hide resolved
leerob
leerob previously approved these changes Mar 4, 2022
Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you've deployed this, we could add it to the README as a demo URL 😄

@leerob leerob changed the title adding Tina CMS [examples] Add Tina CMS blog starter Mar 4, 2022
@perkinsjr
Copy link
Contributor Author

If you've deployed this, we could add it to the README as a demo URL 😄

I actually don't have it deployed. I can come back around once we figure out where it should live (tinacms, my repo etc) and I will add an update to the README.md

@leerob
Copy link
Member

leerob commented Mar 5, 2022

Looks like two small issues in CI:

/home/runner/work/next.js/next.js/examples/blog-starter/components/avatar.js
[412](https://github.com/vercel/next.js/runs/5428495504?check_suite_focus=true#step:5:412)
  7:17  error  Parsing error: Unexpected token, expected "}" (7:17)
[413](https://github.com/vercel/next.js/runs/5428495504?check_suite_focus=true#step:5:413)

[414](https://github.com/vercel/next.js/runs/5428495504?check_suite_focus=true#step:5:414)
/home/runner/work/next.js/next.js/examples/cms-tina/components/avatar.js
[415](https://github.com/vercel/next.js/runs/5428495504?check_suite_focus=true#step:5:415)
  8:17  error  Parsing error: Unexpected token, expected "}" (8:17)
[416](https://github.com/vercel/next.js/runs/5428495504?check_suite_focus=true#step:5:416)

[417](https://github.com/vercel/next.js/runs/5428495504?check_suite_focus=true#step:5:417)
✖ 2 problems (2 errors, 0 warnings)

@perkinsjr
Copy link
Contributor Author

Yup @leerob looks like those were the changes you made to the Avatar. I’ll take a look tomorrow, see why it’s not building.

@perkinsjr
Copy link
Contributor Author

Oh I see the problem the end should be a } but we have a ) on the image width and heights

Change from ) to }
Fixing height and width props
@perkinsjr
Copy link
Contributor Author

Should be all set now👍

leerob
leerob previously approved these changes Mar 5, 2022
@balazsorban44
Copy link
Member

@perkinsjr Could you address the linting issues, otherwise, this would be ok to merge.

See: https://github.com/vercel/next.js/runs/5430503399?check_suite_focus=true

@perkinsjr perkinsjr requested a review from huozhi as a code owner March 5, 2022 15:57
@perkinsjr
Copy link
Contributor Author

This should be good to go now.

@kodiakhq kodiakhq bot merged commit b5cc91e into vercel:canary Mar 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants