Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add _document to with-styled-components example #35163

Merged
merged 3 commits into from Mar 10, 2022
Merged

Re-add _document to with-styled-components example #35163

merged 3 commits into from Mar 10, 2022

Conversation

chemicalkosek
Copy link
Contributor

_document.js was removed from the styled components swc example
I have tested with and without the custom _document.js
Unfortunately without _document.js there is FOUC (Flash of unstyled content) on initial request.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@chemicalkosek
Create _document.js
5aab696 
`_document.js` was removed from the styled components swc example
I have tested with and without the custom `_document.js`
Unfortunately without `_document.js` there is FOUC (Flash of unstyled content) on initial request.
@ijjk ijjk added the examples Issue/PR related to examples label Mar 9, 2022
@chemicalkosek chemicalkosek mentioned this pull request Mar 9, 2022
Merged
@balazsorban44
Copy link
Member

Related #34770 (comment)

pacocoursey
pacocoursey reviewed Mar 10, 2022
View reviewed changes
Copy link
Contributor

@pacocoursey pacocoursey left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - definitely still needed to avoid FOUC on SSR/SSG with styled-components.

ijjk
ijjk approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk changed the title Create _document.js Re-add _document to with-styled-components example Mar 10, 2022
@kodiakhq kodiakhq bot merged commit 7ce5d3f into vercel:canary Mar 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pacocoursey pacocoursey pacocoursey left review comments

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chemicalkosek @balazsorban44 @ijjk @pacocoursey