Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that pages manifest contains pages of both runtimes #35243

Merged
merged 3 commits into from Mar 11, 2022
Merged

Ensure that pages manifest contains pages of both runtimes #35243

merged 3 commits into from Mar 11, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Mar 11, 2022

Previously we only run PagesManifestPlugin in the Node server runtime, because the Edge target doesn't need it as the web server and middleware SSR loader specially handled pages manifest. This cases entrypoints with the Edge runtime configured being missing from there and this PR fixes it.

Part of #31317 and #31506.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Mar 11, 2022
@shuding shuding mentioned this pull request Mar 11, 2022
Merged
10 tasks
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@shuding shuding marked this pull request as ready for review March 11, 2022 10:25
huozhi
huozhi reviewed Mar 11, 2022
View reviewed changes
test/integration/react-streaming-and-server-components/test/runtime.js
@@ -9,4 +13,31 @@ export default async function runtime(context, { runtime }) {
expect(html2).toContain('Runtime: Node.js')
})
}
if (runtime === 'edge' && env === 'prod') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should nodejs runtime be included here as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is mainly for mixed runtimes. Since the page runtime of /runtime and /runtime-rsc is nodejs, we want to test the case that all other pages are using the edge runtime. If we set the global runtime to nodejs, it's not affected by this PR and already works today.

@ijjk
Copy link
Member

ijjk commented Mar 11, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/4f15 Change
buildDuration 15.4s 16.1s ⚠️ +627ms
buildDurationCached 6.2s 6.2s ⚠️ +38ms
nodeModulesSize 378 MB 378 MB ⚠️ +1.09 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/4f15 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.143 3.169 ⚠️ +0.03
/ avg req/sec 795.49 788.99 ⚠️ -6.5
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.367 1.39 ⚠️ +0.02
/error-in-render avg req/sec 1828.74 1798.09 ⚠️ -30.65
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/4f15 Change
925.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 27.9 kB 27.9 kB ✓
webpack-HASH.js gzip 1.44 kB 1.44 kB ✓
Overall change 71.6 kB 71.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/4f15 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/4f15 Change
_app-HASH.js gzip 1.36 kB 1.36 kB ✓
_error-HASH.js gzip 192 B 192 B ✓
amp-HASH.js gzip 309 B 309 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.57 kB 2.57 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 920 B 920 B ✓
image-HASH.js gzip 5.09 kB 5.09 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 2.26 kB 2.26 kB ✓
routerDirect..HASH.js gzip 320 B 320 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 319 B 319 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 14.8 kB 14.8 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/4f15 Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/4f15 Change
index.html gzip 531 B 531 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 525 B 525 B ✓
Overall change 1.6 kB 1.6 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/4f15 Change
buildDuration 19.4s 19.3s -52ms
buildDurationCached 6.2s 6.2s -26ms
nodeModulesSize 378 MB 378 MB ⚠️ +1.09 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/4f15 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.169 3.105 -0.06
/ avg req/sec 788.78 805.19 +16.41
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.378 1.357 -0.02
/error-in-render avg req/sec 1813.75 1842.5 +28.75
Client Bundles (main, webpack)
vercel/next.js canary shuding/next.js shu/4f15 Change
925.HASH.js gzip 178 B 178 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.2 kB 28.2 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 72.2 kB 72.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/4f15 Change
polyfills-HASH.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/4f15 Change
_app-HASH.js gzip 1.35 kB 1.35 kB ✓
_error-HASH.js gzip 179 B 179 B ✓
amp-HASH.js gzip 313 B 313 B ✓
css-HASH.js gzip 324 B 324 B ✓
dynamic-HASH.js gzip 2.56 kB 2.56 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 921 B 921 B ✓
image-HASH.js gzip 5.23 kB 5.23 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 2.33 kB 2.33 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
script-HASH.js gzip 388 B 388 B ✓
withRouter-HASH.js gzip 317 B 317 B ✓
85e02e95b279..7e3.css gzip 107 B 107 B ✓
Overall change 15 kB 15 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/4f15 Change
_buildManifest.js gzip 458 B 458 B ✓
Overall change 458 B 458 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/4f15 Change
index.html gzip 530 B 530 B ✓
link.html gzip 545 B 545 B ✓
withRouter.html gzip 526 B 526 B ✓
Overall change 1.6 kB 1.6 kB ✓
Commit: cf749ad

@kodiakhq kodiakhq bot merged commit 2b13c2f into vercel:canary Mar 11, 2022
@shuding shuding deleted the shu/4f15 branch March 11, 2022 13:34
kodiakhq bot pushed a commit that referenced this pull request Mar 16, 2022
@shuding @huozhi
Make concurrent features independent from the global runtime option (#…
853442d 
…35245)

This PR depends on #35242 and #35243. It allows the global runtime to be unset, as well as enables static optimization for Fizz and RSC pages in the Node.js runtime. Currently for the Edge runtime pages are still always SSR'd.

Closes #31317.

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`


Co-authored-by: Jiachi Liu <4800338+huozhi@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@padmaia padmaia Awaiting requested review from padmaia

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shuding @ijjk @huozhi